-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Port 80 #5495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 80 #5495
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR enables port 80 access for the Onyx application by uncommenting the "80:80"
port mapping in the nginx service configuration. The change allows users to access the application on the standard HTTP port in addition to the existing configurable port (defaulting to 3000). This is a simple infrastructure change that improves accessibility by providing access on the conventional web port.
- Uncommented port 80:80 mapping in nginx service
- No impact on existing HOST_PORT functionality
- Consistent with other deployment configurations (prod, multitenant)
Confidence Score: 4/5
- This PR is safe to merge with minimal risk
- Score reflects a simple, low-risk infrastructure change that only enables additional access without breaking existing functionality
- No files require special attention
Important Files Changed
File Analysis
Filename | Score | Overview |
---|---|---|
deployment/docker_compose/docker-compose.yml | 4/5 | Uncommented port 80:80 mapping for nginx service to enable standard HTTP access |
Sequence Diagram
sequenceDiagram
participant User as User/Browser
participant Docker as Docker Host
participant Nginx as Nginx Container
participant Web as Web Server
participant API as API Server
Note over User, API: Port 80 Access Flow (New)
User->>+Docker: HTTP Request to localhost:80
Docker->>+Nginx: Forward to container port 80
Nginx->>+Web: Proxy to web_server
Web-->>-Nginx: Response
Nginx-->>-Docker: Response
Docker-->>-User: Response
Note over User, API: Existing HOST_PORT Access Flow
User->>+Docker: HTTP Request to localhost:3000 (or HOST_PORT)
Docker->>+Nginx: Forward to container port 80
Nginx->>+Web: Proxy to web_server
Web-->>-Nginx: Response
Nginx-->>-Docker: Response
Docker-->>-User: Response
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
37 Jobs Failed: Run Integration Tests v2 / integration-tests (connector_job_tests/google, connector-google) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (connector_job_tests/jira, connector-jira) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (connector_job_tests/sharepoint, connector-sharepoint) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (connector_job_tests/slack, connector-slack) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/anonymous_user, tests-anonymous_user) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/api_key, tests-api_key) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/auth, tests-auth) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/chat, tests-chat) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/chat_retention, tests-chat_retention) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/connector, tests-connector) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/dev_apis, tests-dev_apis) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/document_set, tests-document_set) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/image_indexing, tests-image_indexing) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/index_attempt, tests-index_attempt) failed on "Wait for service to be ready"
Run Integration Tests v2 / integration-tests (tests/indexing, tests-indexing) failed on "Wait for service to be ready"
15 more jobs failed (See summary below for more details) 7 jobs failed running on non-Blacksmith runners. Summary: 5 successful workflows, 4 failed workflows
Last updated: 2025-09-25 18:39:48 UTC |
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Additional Options
Summary by cubic
Enabled the 80:80 port mapping for the nginx service in docker-compose. The app is now accessible at http://localhost:80, in addition to http://localhost:3000.