Skip to content

Conversation

wenxi-onyx
Copy link
Member

@wenxi-onyx wenxi-onyx commented Sep 25, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Additional Options

  • [Optional] Override Linear Check

Summary by cubic

Renamed the default seeded docs connector from "Sample Use Cases" to "Onyx Docs Overview" to better match the content and reduce UI confusion. Applies to new seeding runs; existing connectors are unchanged.

@wenxi-onyx wenxi-onyx requested a review from a team as a code owner September 25, 2025 22:02
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Sep 25, 2025 10:26pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR updates the seeded connector name from "Sample Use Cases" to "Onyx Docs Overview" in the initial document seeding function. This is a cosmetic change to better reflect the actual content being seeded, which is documentation from docs.onyx.app. The change only affects new installations where documents are seeded for the first time.

Confidence Score: 5/5

  • This PR is completely safe to merge with no risk
  • Single string literal change with no functional impact - purely cosmetic naming improvement
  • No files require special attention

Important Files Changed

File Analysis

Filename        Score        Overview
backend/onyx/seeding/load_docs.py 5/5 Simple string update changing connector name from "Sample Use Cases" to "Onyx Docs Overview" - no issues found

Sequence Diagram

sequenceDiagram
    participant User as User/System
    participant SeederFunc as seed_initial_documents()
    participant DB as Database
    participant KVStore as KV Store
    participant VespaIndex as Vespa Index
    
    User->>SeederFunc: Initialize system (first startup)
    SeederFunc->>KVStore: Check if documents already seeded
    alt Documents not seeded yet
        SeederFunc->>DB: Check if docs/connectors exist
        alt No existing docs/connectors
            SeederFunc->>DB: Create connector with name "Onyx Docs Overview"
            Note over SeederFunc: Updated name from "Sample Use Cases"
            SeederFunc->>DB: Create connector-credential pair
            SeederFunc->>SeederFunc: Load processed docs from JSON
            SeederFunc->>DB: Index documents in PostgreSQL
            SeederFunc->>VespaIndex: Index documents in Vespa
            SeederFunc->>DB: Mock successful index attempt
            SeederFunc->>KVStore: Mark documents as seeded
        else
            SeederFunc->>User: Skip seeding (docs/connectors exist)
        end
    else
        SeederFunc->>User: Skip seeding (already completed)
    end
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wenxi-onyx wenxi-onyx force-pushed the whuang/update-seeded-docs-connector-name branch from 4dd5648 to f53a639 Compare September 25, 2025 22:22
@wenxi-onyx wenxi-onyx merged commit e82b68c into main Sep 25, 2025
55 of 57 checks passed
@wenxi-onyx wenxi-onyx deleted the whuang/update-seeded-docs-connector-name branch September 25, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant