Skip to content

Conversation

justin-tahara
Copy link
Contributor

@justin-tahara justin-tahara commented Sep 25, 2025

Description

[Provide a brief description of the changes in this PR]
There are some additional tests that need to be fixed and this can now be used as a fix since this what we did for the other tests.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Additional Options

  • [Optional] Override Linear Check

@justin-tahara justin-tahara requested a review from a team as a code owner September 25, 2025 22:09
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Ready Ready Preview Comment Sep 25, 2025 10:13pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR fixes a Playwright test infrastructure issue by adding the docker-compose.dev.yml override file to the Docker Compose command. The change enables proper port exposure for services during testing, allowing the health check and Playwright tests to successfully communicate with the API server on localhost:8080.

  • Problem Solved: The original docker compose up -d command only used the base docker-compose.yml file, which doesn't expose service ports to the host system
  • Solution Applied: Added -f docker-compose.dev.yml flag to include the development override file that exposes necessary ports (8080 for API server, 5432 for database, etc.)
  • Impact: Fixes connectivity issues between the GitHub Actions runner and the Onyx services during Playwright test execution

This is a targeted infrastructure fix that follows the established pattern used in other Docker Compose configurations throughout the project.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple infrastructure fix that adds a Docker Compose override file to expose ports needed for testing. It follows established patterns in the codebase and addresses a specific connectivity issue without introducing any new logic or dependencies.
  • No files require special attention

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/pr-playwright-tests.yml 5/5 Added docker-compose.dev.yml override file to expose service ports needed for Playwright tests

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Action
    participant Docker as Docker Compose
    participant API as API Server
    participant PW as Playwright Tests
    
    GH->>+Docker: docker compose -f docker-compose.yml up -d (before)
    Note over Docker: Services start without exposed ports
    Docker-->>-GH: Services running internally
    
    GH->>API: curl http://localhost:8080/health
    Note over API: Port 8080 not accessible from host
    API-->>GH: Connection refused/timeout
    
    Note over GH: Fix Applied
    
    GH->>+Docker: docker compose -f docker-compose.yml -f docker-compose.dev.yml up -d (after)
    Note over Docker: Services start with ports exposed via dev override
    Docker-->>-GH: Services running with exposed ports
    
    GH->>API: curl http://localhost:8080/health
    API-->>GH: HTTP 200 OK
    
    GH->>+PW: npx playwright test
    PW->>API: HTTP requests to localhost:8080
    API-->>PW: Responses
    PW-->>-GH: Tests complete successfully
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@justin-tahara justin-tahara merged commit af5eec6 into main Sep 25, 2025
56 of 59 checks passed
@justin-tahara justin-tahara deleted the jtahara/fix-playwright branch September 25, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant