Skip to content

Commit a81b124

Browse files
authored
fix #111 (#114)
1 parent 67c83d2 commit a81b124

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/sdk/src/metric/metric_reader.jl

+5-1
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,17 @@ MetricReader() = MetricReader(global_meter_provider(), ConsoleExporter())
5959
6060
For async instruments in `r`, their callbacks will be executed first before reading all the metrics.
6161
"""
62-
function (r::MetricReader)()
62+
function (r::MetricReader{<:MeterProvider})()
6363
for ins in r.provider.async_instruments
6464
ins()
6565
end
6666
export!(r.exporter, metrics(r.provider))
6767
end
6868

69+
function (r::MetricReader)()
70+
export!(r.exporter, metrics(r.provider))
71+
end
72+
6973
# ??? close provider?
7074
Base.close(r::MetricReader) = close(r.exporter)
7175

src/sdk/test/metric.jl

+7
Original file line numberDiff line numberDiff line change
@@ -247,3 +247,10 @@ end
247247
@test length(e) == 1
248248
@test e.pool[1].name == "Y"
249249
end
250+
251+
@testset "#111" begin
252+
p = OpenTelemetryAPI.DummyMeterProvider()
253+
e = InMemoryExporter()
254+
r = MetricReader(p, e)
255+
r()
256+
end

0 commit comments

Comments
 (0)