Remove unused or rarely used features #221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
force-pushed
the
no-ocds-show
branch
from
3e55fd8 to
48bc988
Compare
conversion_error and conversion_warning_messages_titles are relevant to convert_json only
…on (within a major version).
…low_direct_web_fetch and VALIDATION_ERROR_LOCATIONS_LENGTH.
…titution variables to not contain periods
…d by lib-cove-ocds
Non-merge changes: - Add server_url to submit_file, to encapsulate environment variables in tests/conftest.py and tests/__init__.py - Remove mocks from test_flattentool_warnings and fix assertions to match template text - Revert these changes from accidental commit 6910617, to get tests passing: - A tests/test_util.py - A tests/test_validation_errors.py - D tests/fixtures/tenders_releases_2_releases_with_deprecated_fields.json - D tests/fixtures/release_package_schema_ref_release_schema_deprecated_fields.json Resolve conflicts: - test_functional.py: Change modal tests to new maximum length - test_view.py: - Use HTTP status codes - An invalid version has no special logic - Remove flattening JSON, changing version, releases/records table, KFI table, error sampling - Remove test_styles_500_error (handler500 was removed in 90e5bde along with test_500_error)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26, closes #57
Re: duplicate release IDs: "Non-unique combination of ocid, id values" is already reported as a validation error. Release IDs are allowed to repeat.
"contracts_without_awards" is removed; it is useful, but I don't think anyone sees it in the Key Field Information table. We do that check in Pelican.