Skip to content

Commit 2a2a93a

Browse files
committed
docs: Move SSRF from comment to docstring
1 parent 46f5756 commit 2a2a93a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

ocdskit/combine.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,11 @@ def merge(
168168
If ``return_package`` is set and ``publisher`` isn't set, the output record package will have the same publisher as
169169
the last input release package.
170170
171+
.. attention::
172+
173+
This function is vulnerable to server-side request forgery (SSRF). A user can create a release package or
174+
record package whose extension URLs point to internal resources, which would receive a GET request.
175+
171176
:param data: an iterable of release packages and individual releases
172177
:param uri: if ``return_package`` is ``True``, the record package's ``uri``
173178
:param publisher: if ``return_package`` is ``True``, the record package's ``publisher``
@@ -195,7 +200,6 @@ def merge(
195200
tag = get_ocds_patch_tag(packager.version)
196201
if packager.package['extensions']:
197202
# `extensions` is an insertion-ordered dict at this point.
198-
# Security: Potential SSRF via extension URLs.
199203
builder = ProfileBuilder(tag, list(packager.package['extensions']))
200204
schema = builder.patched_release_schema()
201205
else:

0 commit comments

Comments
 (0)