-
Notifications
You must be signed in to change notification settings - Fork 737
Fix/1370 efficientad validation and pretraining images #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I additionally adressed an issue raise in this discussion #1368 The option |
batch_size: int = 1, | ||
pretraining_images_dir: str = "./datasets/imagenette", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to make this parameter optional? That way, if it is None
you can still do the automatic download of the Imagenet dataset.
Co-authored-by: Sean Aubin <seanaubin@gmail.com>
Description
Fixes issues A and C in #1370
A: make it possible to split the train set to make a validation set.
C: make it possible to point to a directory with the images that should be used to the penalty term in the student loss of efficientad.
Known issue: the vocabulary in the classes for EfficientAD say "imagenette" everywhere, while it's more generally the image set used for the pretraining (could be something else). While I set the option name to
pretraining_images_dir
, i think it'd be better to align things.Changes
Describe the changes you made
Checklist
Ensure that you followed the following