Skip to content

Conversation

dwesolow
Copy link

@dwesolow dwesolow commented Sep 29, 2025

πŸ“ Description

Update UI scripts to use 8000 port when using server to fetch OpenAPI schema and generate types.

✨ Changes

Select what type of change your PR is:

  • πŸš€ New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”„ Refactor (non-breaking change which refactors the code base)
  • ⚑ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • πŸ§ͺ Tests (adding/modifying tests)
  • πŸ“š Documentation update
  • πŸ“¦ Build system changes
  • 🚧 CI/CD configuration
  • πŸ”§ Chore (general maintenance)
  • πŸ”’ Security update
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

@dwesolow dwesolow self-assigned this Sep 29, 2025
@dwesolow dwesolow changed the base branch from main to feature/geti-inspect September 29, 2025 08:24
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

βœ… All modified and coverable lines are covered by tests.

πŸ“’ Thoughts on this report? Let us know!

Copy link

@MarkRedeman MarkRedeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note on the we can also set the port via the HTTP_SERVER_PORT environment variable.
Long term I think we should make it so that when in development mode the UI also uses this variable.
In addition we could have a /app/.env.example file that we tell people to copy over to /app/.env which would then get read by both the client and server?

@dwesolow dwesolow merged commit 4ff7111 into feature/geti-inspect Sep 29, 2025
14 of 17 checks passed
@dwesolow dwesolow deleted the dwesolow/update-ui-scripts branch September 29, 2025 10:14
MarkRedeman pushed a commit that referenced this pull request Oct 8, 2025
* chore(inspect): Update UI scripts

* chore: Update github actions

* chore: Update port to 8000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants