🔧 chore(inspect): Configure project(s) mocks for playwright tests #2978
Conversation
dwesolow
requested review from
ashwinvaidya17 and
samet-akcay
as code owners
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| }, | ||
| { | ||
| settings: { | ||
| 'import/resolver': { |
There was a problem hiding this comment.
It allows eslint to parse path imports properly when we have more than one tsconfig.json
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@geti-inspect/test-fixtures": ["./fixtures"] |
There was a problem hiding this comment.
Could we rename the file to be test-fixtures as well? Atm I think it could be confusing if you'd try to search for the file related to test-fixtures since the name is different.
There was a problem hiding this comment.
Ok, will rename it in a project management PR since I need to rebase there.
There was a problem hiding this comment.
I'm wondering if it makes sense to rename (to add prefix test) if the file already is in the tests context?
3 participants
📝 Description
This PR adds mocks for project(s) to be used in playwright tests. This PR is needed for #2977
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.