Skip to content

Move segment-anything tool #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 24, 2025
Merged

Move segment-anything tool #4735

merged 29 commits into from
Sep 24, 2025

Conversation

jpggvilaca
Copy link
Contributor

@jpggvilaca jpggvilaca commented Sep 19, 2025 •
edited
Loading

Summary

  • Update lockfile
  • Move SAM files from Geti Classic & update imports/interfaces

Most files are fully copy-paste, with the only change on the mediaItem, that we get from useAnnotator

Video:
https://github.com/user-attachments/assets/977dfc56-48c6-43f5-86f2-5a59d4bb4914

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@jpggvilaca jpggvilaca added the Geti Tune UI Issues related to Geti Tune Studio UI label Sep 19, 2025
@jpggvilaca jpggvilaca mentioned this pull request Sep 19, 2025
Closed
8 tasks
@jpggvilaca jpggvilaca linked an issue Sep 19, 2025 that may be closed by this pull request
Extract interactive segmentation tool #4612
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2025 •
edited
Loading

Docker Image Sizes

Image Size
geti-tune-pr-4735 1.2G
geti-tune-sha-7515d8e 1.2G

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2025 •
edited
Loading

📊 Test coverage report

Metric Coverage
Lines 27.7%
Functions 26.6%
Branches 85.2%
Statements 27.7%

jpggvilaca
jpggvilaca commented Sep 19, 2025
View reviewed changes
jpggvilaca
jpggvilaca commented Sep 19, 2025
View reviewed changes
@jpggvilaca jpggvilaca force-pushed the jvilaca/move-sam-tool branch 2 times, most recently from beddfce to 669e9e1 Compare September 19, 2025 13:29
camiloHimura
camiloHimura reviewed Sep 19, 2025
View reviewed changes
camiloHimura
camiloHimura reviewed Sep 19, 2025
View reviewed changes
camiloHimura
camiloHimura reviewed Sep 19, 2025
View reviewed changes
@jpggvilaca jpggvilaca force-pushed the jvilaca/move-sam-tool branch from 010aacc to 037a772 Compare September 22, 2025 06:51
MarkRedeman
MarkRedeman reviewed Sep 22, 2025
View reviewed changes
MarkRedeman
MarkRedeman reviewed Sep 22, 2025
View reviewed changes
MarkRedeman
MarkRedeman reviewed Sep 22, 2025
View reviewed changes
@jpggvilaca jpggvilaca removed the Draft label Sep 22, 2025
MarkRedeman
MarkRedeman reviewed Sep 22, 2025
View reviewed changes
MarkRedeman
MarkRedeman reviewed Sep 22, 2025
View reviewed changes
@jpggvilaca jpggvilaca merged commit 85b77ad into develop Sep 24, 2025
28 checks passed
@jpggvilaca jpggvilaca deleted the jvilaca/move-sam-tool branch September 24, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkRedeman MarkRedeman MarkRedeman left review comments

@camiloHimura camiloHimura camiloHimura approved these changes

@dwesolow dwesolow dwesolow approved these changes

@pplaskie pplaskie Awaiting requested review from pplaskie

@romanowska romanowska Awaiting requested review from romanowska

Assignees
No one assigned
Labels
Geti Tune UI Issues related to Geti Tune Studio UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract interactive segmentation tool
4 participants
@jpggvilaca @MarkRedeman @camiloHimura @dwesolow