Skip to content

Conversation

camiloHimura
Copy link
Contributor

Summary

Implements removing multiple elements #4699

Screen.Recording.2025-09-22.at.16.42.44.mov

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@camiloHimura camiloHimura added the Geti Tune UI Issues related to Geti Tune Studio UI label Sep 22, 2025
Copy link

github-actions bot commented Sep 22, 2025

Docker Image Sizes

Image Size
geti-tune-pr-4745 1.1G
geti-tune-sha-be85dc2 1.1G

@MarkRedeman
Copy link
Contributor

Quick comment: I feel like the multiple toasts are a bit too much, especially since they don't show a name (i.e. UUIDs) that is nice to read.
Is it possible to make it so that there is 1 notification that says" 10 images removed" or something like that?
Alternatively the user can already see that the images have been removed after we refresh the media list so maybe we don't even need a toast notification for this?

@jpggvilaca
Copy link
Contributor

Quick comment: I feel like the multiple toasts are a bit too much, especially since they don't show a name (i.e. UUIDs) that is nice to read. Is it possible to make it so that there is 1 notification that says" 10 images removed" or something like that? Alternatively the user can already see that the images have been removed after we refresh the media list so maybe we don't even need a toast notification for this?

Im ok with the notification but like i commented before, it's better to display a quantity, or else this won't scale. I dont want to see 50 ids if i remove 50 images. The number is more than enough for me to confirm imho

@camiloHimura
Copy link
Contributor Author

Quick comment: I feel like the multiple toasts are a bit too much, especially since they don't show a name (i.e. UUIDs) that is nice to read. Is it possible to make it so that there is 1 notification that says" 10 images removed" or something like that? Alternatively the user can already see that the images have been removed after we refresh the media list so maybe we don't even need a toast notification for this?

Im ok with the notification but like i commented before, it's better to display a quantity, or else this won't scale. I dont want to see 50 ids if i remove 50 images. The number is more than enough for me to confirm imho

Goos Point, updated

Copy link

📊 Test coverage report

Metric Coverage
Lines 29.6%
Functions 30.1%
Branches 85.7%
Statements 29.6%

@camiloHimura camiloHimura merged commit 732a289 into develop Sep 23, 2025
28 checks passed
@camiloHimura camiloHimura deleted the ccolora11/4699-dataset-api-p3 branch September 23, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Geti Tune UI Issues related to Geti Tune Studio UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants