build: Set language to latest #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
- Updated DictionaryConverter to improve code clarity and structure. - Enhanced JsonConverterExtensions with better documentation. - Refined OpenFeatureStructureConverter and OpenFeatureValueConverter for consistency and readability. - Simplified exception classes (FlagDisabled, FlagNotFoundError, GeneralError, etc.) by removing unnecessary comments and improving documentation. - Improved error handling in GoFeatureFlagException and its derived classes. - Streamlined the implementation of GoFeatureFlagExtensions for better usability. - Enhanced EnrichEvaluationContextHook to clarify its purpose and improve metadata handling. - Refactored ExporterMetadata to encapsulate metadata building logic more effectively. - Improved the structure and clarity of OfrepRequest and OfrepResponse classes. Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
|
Converting this to draft until #386 is merged |
# Conflicts: # src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj # src/OpenFeature.Contrib.Providers.Flipt/OpenFeature.Contrib.Providers.Flipt.csproj # src/OpenFeature.Contrib.Providers.GOFeatureFlag/OpenFeature.Contrib.Providers.GOFeatureFlag.csproj # test/OpenFeature.Contrib.Providers.Flipt.Test/OpenFeature.Contrib.Providers.Flipt.Test.csproj
# Conflicts: # src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj # src/OpenFeature.Contrib.Providers.GOFeatureFlag/OpenFeature.Contrib.Providers.GOFeatureFlag.csproj
kylejuliandev
approved these changes
May 12, 2025
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
May 30, 2025
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weyert de Boer <weyert@innerfuse.biz>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weyert de Boer <weyert@innerfuse.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request includes updates to the project setup, language version requirements, and namespace declarations across multiple files. The most significant changes involve updating the .NET version recommendation, removing explicit language version declarations, and adopting file-scoped namespaces for improved readability and consistency.
Project Setup and Requirements:
CONTRIBUTING.md. Removed references to specific C# language versions in project setup instructions.CONTRIBUTING.mdfor clarity and consistency.Language Version Simplification:
<LangVersion>property from.csprojfiles in several projects (OpenFeature.Contrib.Providers.Flagsmith,OpenFeature.Contrib.Providers.Flipt, andOpenFeature.Contrib.Providers.GOFeatureFlag). This change relies on the default language version provided by the target framework. [1] [2] [3]Namespace Modernization:
OpenFeature.Contrib.Providers.GOFeatureFlagdirectory, includingGoFeatureFlagProvider.cs,GoFeatureFlagProviderOptions.cs, and various exception and converter files. This change improves readability and aligns with modern C# conventions. [1] [2] [3] [4] [5] and others)These changes collectively modernize the codebase, simplify project configuration, and enhance maintainability.