Skip to content

Conversation

hyq-hub
Copy link
Contributor

@hyq-hub hyq-hub commented Oct 25, 2024

✨ Description

[Please describe the background, purpose, changes made, and how to test this PR]

🚧 Related Issues

[List the issue numbers related to this PR]

👨‍💻 Changes Proposed

  • change1
  • ...

🧑‍🤝‍🧑 Who Can Review?

[Please use the '@' symbol to mention any community member who is free to review the PR once the tests have passed. Feel free to tag members or contributors who might be interested in your PR.]

🛠 TODO

  • task1
  • ...

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@hyq-hub hyq-hub marked this pull request as draft October 28, 2024 09:04
@hyq-hub hyq-hub marked this pull request as ready for review October 28, 2024 09:06
@hyq-hub hyq-hub changed the title Add Debatts Some Code Add Debatts Some Code Oct 28, 2024
@hyq-hub
Copy link
Contributor Author

hyq-hub commented Oct 28, 2024

Who Can Review?
@RMSnow @HeCheng0625 @jiaqili3

Copy link
Collaborator

@yuantuo666 yuantuo666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a README to introduce Debatts, also an env.sh about environment configuration file if needed.

@torch.no_grad()
def sample_hf(
self,
phone_ids, # the phones of prompt and target should be concatenated together。在实际使用中,phone_ids是文本的token输入
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use English comments in the code. It's the same for other files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jiaqili3 jiaqili3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiaqili3 jiaqili3 dismissed yuantuo666’s stale review January 2, 2025 04:17

revolved by author

@jiaqili3 jiaqili3 merged commit c0b0df0 into open-mmlab:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants