Skip to content

[Feature] Add ceph and petrel support for LoadMultiViewImageFromFiles #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev-1.0
Choose a base branch
from

Conversation

Lotus-95
Copy link

Motivation

Add ceph and petrel support for LoadMultiViewImageFromFiles

Modification

Add ceph and petrel support for LoadMultiViewImageFromFiles

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.97%. Comparing base (a362df2) to head (47b8f4a).
Report is 28 commits behind head on dev-1.0.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.0    #1651      +/-   ##
===========================================
- Coverage    50.00%   49.97%   -0.03%     
===========================================
  Files          228      228              
  Lines        19916    19917       +1     
  Branches      3187     3187              
===========================================
- Hits          9958     9953       -5     
- Misses        9368     9374       +6     
  Partials       590      590              
Flag Coverage Δ
unittests 49.97% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tai-Wang
Copy link
Member

Tai-Wang commented Aug 3, 2022

Hi @Lotus-95 , coud you please sign the CLA as reminded above?

@Lotus-95
Copy link
Author

Lotus-95 commented Aug 9, 2022

@Tai-Wang I've already signed.

@Tai-Wang
Copy link
Member

Hi @Lotus-95 , thanks for your contribution! Could you please use pre-commit hook following this guide to fix the linting errors?

@ZwwWayne ZwwWayne changed the base branch from master to dev September 29, 2022 12:01
@ZwwWayne ZwwWayne changed the base branch from dev to master September 29, 2022 12:02
@ZwwWayne ZwwWayne added this to the 1.0.0rc5 milestone Sep 29, 2022
@ZwwWayne ZwwWayne changed the base branch from master to dev December 2, 2022 08:09
* changelog of 1.0.0rc6

* resolve comments

* update changelog

* update date in changelog

* update date in changelog
@ZwwWayne ZwwWayne removed this from the 1.0.0rc5 milestone Dec 19, 2022
@OpenMMLab-Assistant-004

Hi @Lotus-95 !We are grateful for your efforts in helping improve mmdetection3d open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

@Lotus-95 Lotus-95 requested a review from Tai-Wang February 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants