Skip to content

[WIP] [Feature] CodeCamp #42 Support FSD #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev-1.x
Choose a base branch
from

Conversation

PeterH0323
Copy link
Contributor

Motivation

Support FSD

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

@PeterH0323 PeterH0323 changed the title [WIP Feature] Support FSD [WIP Feature] CodeCamp #42 Support FSD Dec 2, 2022
@ZCMax ZCMax changed the title [WIP Feature] CodeCamp #42 Support FSD [WIP] [Feature] CodeCamp #42 Support FSD Dec 2, 2022
@ZwwWayne ZwwWayne force-pushed the dev-1.x branch 2 times, most recently from 72b8e9f to 28fe73d Compare December 3, 2022 08:47
@Abyssaledge
Copy link

Dear maintainers, @PeterH0323 I come across this PR, and thanks for your efforts to support FSD. I may offer some help if you need, for example, the model weights for inference debugging.
There are some experiences to support FSD in MMDet3D > v1.0. (1) The coordinate system in DynamicPointPooling should be paid attention to. (2) IoUNegPiecewiseSampler in original FSD seems to be different from the one in the new MMDet3D.
Further discussions are definitely welcome!

@PeterH0323
Copy link
Contributor Author

Dear maintainers, @PeterH0323 I come across this PR, and thanks for your efforts to support FSD. I may offer some help if you need, for example, the model weights for inference debugging. There are some experiences to support FSD in MMDet3D > v1.0. (1) The coordinate system in DynamicPointPooling should be paid attention to. (2) IoUNegPiecewiseSampler in original FSD seems to be different from the one in the new MMDet3D. Further discussions are definitely welcome!

Hi, the creator of FSD @Abyssaledge 😄
Thx for the advice. May i ask, do you have some time, maybe we can support it together on MMDet3d 1.x ?

@Abyssaledge
Copy link

@PeterH0323 I cannot promise enough time, but I can help with the code review, problem discussion and lightweight commits. You could search my github username in wechat for further communication :)

@ZwwWayne ZwwWayne requested a review from JingweiZhang12 March 20, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants