Skip to content

Make mmseg to be able to run on mmcv=2.2.0 #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make mmseg to be able to run on mmcv=2.2.0 #3663

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
119265e
Make mmseg to be able to run on mmcv=2.2.0
rabinadk1 May 9, 2024
e2e2b80
Bump the MMCV_MAX to 2.3.0 and avoid changing the comparision logic t…
rabinadk1 May 9, 2024
ccddc32
Keep the MMCV_MAX version the same but add equals operator on the ass…
rabinadk1 Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions mmseg/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from .version import __version__, version_info

MMCV_MIN = '2.0.0rc4'
MMCV_MAX = '2.2.0'
MMCV_MAX = '2.3.0'
Copy link
Contributor

@MGAMZ MGAMZ May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly changing the support version may be dangerous

MMENGINE_MIN = '0.5.0'
MMENGINE_MAX = '1.0.0'

Expand Down Expand Up @@ -58,17 +58,23 @@ def digit_version(version_str: str, length: int = 4):
mmcv_version = digit_version(mmcv.__version__)


assert (mmcv_min_version <= mmcv_version < mmcv_max_version), \
assert (mmcv_version >= mmcv_min_version), \
f'MMCV=={mmcv.__version__} is used but incompatible. ' \
f'Please install mmcv>=2.0.0rc4.'
f'Please install mmcv>={MMCV_MIN}.'

assert (mmcv_version < mmcv_max_version), \
f'MMCV=={mmcv.__version__} is used but incompatible. ' \
f'Please install mmcv<{MMCV_MAX}.'

mmengine_min_version = digit_version(MMENGINE_MIN)
mmengine_max_version = digit_version(MMENGINE_MAX)
mmengine_version = digit_version(mmengine.__version__)

assert (mmengine_min_version <= mmengine_version < mmengine_max_version), \
assert (mmengine_version >= mmengine_version), \
f'MMEngine=={mmengine.__version__} is used but incompatible. ' \
f'Please install mmengine>={mmengine_min_version}, '\
f'<{mmengine_max_version}.'
f'Please install mmengine>={MMENGINE_MIN}.'

assert (mmengine_version < mmengine_max_version), \
f'MMEngine=={mmengine.__version__} is used but incompatible. ' \
f'Please install mmengine<{MMENGINE_MAX}.'
__all__ = ['__version__', 'version_info', 'digit_version']