v5.0.x: Fix Libfabric MR caching issues #13327 #13332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an optimization around a bug in the EFA provider. The EFA provider shouldn't be caching explicit registrations anyway, so avoiding the double cache is silly (and breaks when EFA fixes the explicit registration cache bug). Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit c3e22c6)
The OFI MTL exports a memory monitor to Libfabric (so that OMPI's patcher wins), but in cases where OB1 is directly selected, that code won't run. So make sure to also configure Libfabric so that it won't try to use a suboptimial memory monitor in the case that only the OFI BTL is used. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 937429f)
Rather than use the CXI provider name to disable explicit hmem registration, use the FI_MR_HMEM flag. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit edf3634)
The OFI MTL was creating a registration for every operation that used HMEM when FI_MR_HMEM is required. This is really performance inefficient, since creating registrations is expensive. So stick a rcache in front of the registrations. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 72a7e0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13327.