-
Notifications
You must be signed in to change notification settings - Fork 787
doc: Add a page to include all flag information in one place #3358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
@JaydipGabani Could you share more about the scope / audience of this doc? For example, is it for users or developers (or both)? I ask because I found a handful of flags that aren't exposed as chart values and are not applied to the underlying deployments:
|
@ianstanton I think this is for both. I recall someone not being able to find information about a flag and incompatible behavior because it was hidden in documentation as warning for two imcompatible flags. As oppose to that, if all the flags are in one place then it might be useful to get the information on what the flag does easily. And then if users want to know more, they can read through respective feature documentation. |
@JaydipGabani Cool, thanks for clarifying! So any flag could be passed when running the binary, but I think we should also add those missing flags I mentioned in #3358 (comment) to the chart as part of this unless there's a reason they're not exposed. My thought is users should be able to set any available flag via the helm chart as well, and it doesn't look like they can at the moment. We could add the missing flags as individual helm values, or add a I can keep this simple for now and add a docs page with a table for each flag. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
It may be helpful for users to get all the information about available flags, their catagory of use (audit, webhook, mutation) into one consolidated page.
The text was updated successfully, but these errors were encountered: