feat: support print statement in gator (#2949) #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serializator
force-pushed
the
gator-support-print-statement
branch
2 times, most recently
from
3508492 to
f8fc481
Compare
Signed-off-by: Julian van den Berkmortel <7153670+Serializator@users.noreply.github.com>
Serializator
force-pushed
the
gator-support-print-statement
branch
from
f8fc481 to
9e41d23
Compare
JaydipGabani
requested changes
Apr 7, 2025
There was a problem hiding this comment.
@Serializator Thanks for the PR. For completeness this should be added to gator test as well. Since verbose flag does not exists in gator test I recommend adding verbose flag there or enable print with trace in both since trace flag exists for verify and test or introduce a new flag for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the
printstatement in Gator for easier debugging. The workaround suggested in #2949 was to use thetracestatement with-tbut due to the excess amount of logs the debug statements are lost.This PR re-uses the existing
--verbose / -vflag so not to add yet another command-line flag. If a separate command-line flag is preferred, this can easily be added.Which issue(s) this PR fixes:
Fixes #2949