-
Notifications
You must be signed in to change notification settings - Fork 834
ci: updating runners to ubuntu 24 #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates all GitHub Actions workflow files to use Ubuntu 24.04 runners instead of Ubuntu 22.04, ensuring the CI/CD pipeline runs on the latest LTS Ubuntu version for improved security, performance, and toolchain support.
- Updates runner OS version across all workflow files from ubuntu-22.04 to ubuntu-24.04
- Maintains consistent runner environment across all CI/CD jobs (build, test, lint, release, etc.)
- Adds a new Gatekeeper chatmode configuration file for development assistance
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/workflow.yaml | Updates 4 jobs to use ubuntu-24.04 runners |
| .github/workflows/website.yaml | Updates 2 jobs to use ubuntu-24.04 runners |
| .github/workflows/upgrade.yaml | Updates helm upgrade test job to use ubuntu-24.04 |
| .github/workflows/unit-test.yaml | Updates unit test job to use ubuntu-24.04 |
| .github/workflows/test-gator.yaml | Updates gator test job to use ubuntu-24.04 |
| .github/workflows/scorecards.yml | Updates scorecard analysis job to use ubuntu-24.04 |
| .github/workflows/scan-vulns.yaml | Updates 2 vulnerability scanning jobs to use ubuntu-24.04 |
| .github/workflows/release.yaml | Updates tagged release job to use ubuntu-24.04 |
| .github/workflows/release-pr.yaml | Updates release PR creation job to use ubuntu-24.04 |
| .github/workflows/pre-release.yaml | Updates pre-release job to use ubuntu-24.04 |
| .github/workflows/patch-docs.yaml | Updates patch docs job to use ubuntu-24.04 |
| .github/workflows/lint.yaml | Updates lint job to use ubuntu-24.04 |
| .github/workflows/license-lint.yaml | Updates license lint job to use ubuntu-24.04 |
| .github/workflows/helm-lint.yaml | Updates helm lint job to use ubuntu-24.04 |
| .github/workflows/disk-export.yaml | Updates disk export test job to use ubuntu-24.04 |
| .github/workflows/dependency-review.yml | Updates dependency review job to use ubuntu-24.04 |
| .github/workflows/dapr-export.yaml | Updates dapr export test job to use ubuntu-24.04 |
| .github/workflows/codeql.yaml | Updates CodeQL analysis job to use ubuntu-24.04 |
| .github/workflows/check-manifest.yaml | Updates manifest check job to use ubuntu-24.04 |
| .github/workflows/benchmark.yaml | Updates benchmark job to use ubuntu-24.04 |
| .github/chatmodes/gatekeeper.chatmode.md | Adds new chatmode configuration file for Gatekeeper development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was meant for my local. Removing this.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #4149 +/- ##
===========================================
- Coverage 54.49% 40.65% -13.85%
===========================================
Files 134 251 +117
Lines 12329 17720 +5391
===========================================
+ Hits 6719 7204 +485
- Misses 5116 9890 +4774
- Partials 494 626 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
3e43536 to
7e3aeb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
.github/workflows/benchmark.yaml
Outdated
| name: "Benchmark" | ||
| if: github.event.issue.pull_request && github.event.comment.body == '/benchmark' | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-latest-8-cores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| runs-on: ubuntu-latest-8-cores | |
| runs-on: ubuntu-24.04 |
| check_manifest: | ||
| name: "Check codegen and manifest" | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep pinned ones pinned unless we need more perf such as build workflow one
|
@sozercan IMO we should either keep all pinned or all on latest. I am concerned about the pinned ones going stale while "latest" are moving along. |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: