fix: validatingWebhookExemptNamespacesLabels values are not quoted #4217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderma
force-pushed
the
4211
branch
2 times, most recently
from
717784d to
0ec4f22
Compare
sanderma
changed the title
JaydipGabani
changed the title
JaydipGabani
requested changes
Nov 5, 2025
Contributor
JaydipGabani
left a comment
JaydipGabani
left a comment
There was a problem hiding this comment.
@sanderma Thanks for raising this pr. Any changes in charts will be overwritten during release, ptal - https://open-policy-agent.github.io/gatekeeper/website/docs/help#contributing-to-helm-chart for guidance on updating charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Helm,
validatingWebhookExemptNamespacesLabels:values are not quoted, "true" is read as boolWhich issue(s) this PR fixes (optional, using
yes yes nofixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #4211
Special notes for your reviewer: