Add support for ML-DSA pre-hash sign ACVP test vectors#2362
Merged
dstebila merged 19 commits intoopen-quantum-safe:mainfrom Feb 11, 2026
Merged
Add support for ML-DSA pre-hash sign ACVP test vectors#2362dstebila merged 19 commits intoopen-quantum-safe:mainfrom
dstebila merged 19 commits intoopen-quantum-safe:mainfrom
Conversation
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <ak9070@gmail.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
abhi-dev-engg
requested review from
baentsch,
bhess and
dstebila
as code owners
abhi-dev-engg
force-pushed
the
prehash_dsa
branch
from
ad93264 to
7b03eae
Compare
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
Signed-off-by: Abhi S <saxena_abhinav@icloud.com>
dstebila
approved these changes
Feb 10, 2026
ashman-p
approved these changes
Feb 11, 2026
github-project-automation
bot
moved this from In review
to Done
in 0.16.0 prioritization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for pre-hash sign gen/verify APIs that are supported now via the mldsa-native package.
The tests were disabled previously as the pq-crystals package was not supporting these APIs.
Since these are tested via "prehash internal APIs" the hash of the message is calculated internally(in python test script) and the hash value is passed off as "msg" in the API call.
The test source handles these cases in seperate test APIs so that based on the decision things later could be handled without shuffling much stuff.
With this PR and the previous one complete ACVP vectors for ML-DSA are testable that were previously skipped.