Skip to content

Use gcc9 and ubuntu-20.04 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Use gcc9 and ubuntu-20.04 #723

merged 3 commits into from
Nov 28, 2022

Conversation

markaren
Copy link
Contributor

@markaren markaren commented Nov 22, 2022

As discussed in the OSP meeting, removing gcc7.

Closes #719

Mhhh.. This triggered #717

@restenb
Copy link
Member

restenb commented Nov 23, 2022

I can look at this a bit now, since we would really like a new release. Once this is fixed I can organize a release of libcosim & dependent tools as well.

I'm not really that much into C++ build problems, so can't guarantee I'll be able to fix it... @kyllingstad, do you have any time to spare for this in the coming days?

@davidhjp01
Copy link
Contributor

davidhjp01 commented Nov 25, 2022

For the error
image

I see in our cmake file

target_compile_definitions(cosim PUBLIC "BOOST_ALL_NO_LIB=0" "BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE=1")

Wondering whether the intention of "BOOST_ALL_NO_LIB=0" here is to turn on or off this feature (by setting it to zero)? Because it seems boost just checks the definition of the macro not its value.

Also it seems FindBoost adds BOOST_ALL_NO_LIB to the build, see the below (duplicated definitions):
image

So my suggestion is to remove "=0" part in the cmake file if our intention is to enable "BOOST_ALL_NO_LIB". At least this resolved the issue when I built libcosim locally.

Tested in a separate branch: https://github.com/open-simulation-platform/libcosim/actions/runs/3547760474

@kyllingstad
Copy link
Member

Good catch, @davidhjp01. It makes no sense to set BOOST_ALL_NO_LIB=0; the macro only exists as a means to disable autolinking. But I suggest we just remove the =0 part as you suggest, because earlier FindBoost versions might not set it automatically.

@markaren markaren merged commit f8d17b1 into master Nov 28, 2022
@markaren markaren deleted the deprecate_ubuntu-18.05 branch November 28, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Ubuntu-18.04 environment is deprecated and will be removed on December 1st, 2022
4 participants