Skip to content

Conversation

soywod
Copy link
Contributor

@soywod soywod commented Apr 22, 2025

Reference : #232

@brotskydotcom
Copy link
Collaborator

This is not a useful simplification, because combining all the platform dependencies into a single feature doesn't allow someone to use, for example, the apple-native support on macOS while using linux-keyutils (but NOT secret-service) on linux (because clients can't enable dependencies unless there's a specific feature they can use to enable them). So I'm going to close this pull request.

What I was hoping you were going to do was to create a separate crate that does what your "linux-keyutils-persistent" keystore used to do, that is, combine the functionality of the linux-keyutils keystore and the secret-service keystore. The Cargo.toml for that crate would then be a great example of how you build using multiple keystores on the same platform.

@soywod
Copy link
Contributor Author

soywod commented Apr 23, 2025

What I was hoping you were going to do was to create a separate crate that does what your "linux-keyutils-persistent" keystore used to do, that is, combine the functionality of the linux-keyutils keystore and the secret-service keystore. The Cargo.toml for that crate would then be a great example of how you build using multiple keystores on the same platform.

I see. So you confirm that everything we said in the other thread was done except for this linux-keyutils-persistent?

@soywod soywod deleted the refactor branch April 23, 2025 07:29
@brotskydotcom
Copy link
Collaborator

So you confirm that everything we said in the other thread was done except for this linux-keyutils-persistent?

Yes, exactly. I’ve submitted PRs for the crate extensions for the old features sync-secret-service (keystore feature in dbus-secret-service), async-secret-service (keystore feature in secret-service), and linux-keyutils (keystore feature in linux-keyutils), and I am working with the maintainers to get them accepted. The old sync-secret-service feature (now called just secret-service) will remain the default in this crate (and use the keystore feature in dbus-secret-service). So what we need now is a new crate that combines them into a single keystore.

Feel free to wait until I can get all the other crates released with the PRs in them 🙂. I have to wait for that before I can release v4.0.0 of keyring, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants