Skip to content

Commit aecc4f4

Browse files
committed
Remove redundant codes and optimize comments.
1 parent b461740 commit aecc4f4

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ struct OtlpGrpcClientOptions
9494

9595
/**
9696
* Optional caller-provided gRPC channel arguments.
97-
* This is a non-owning pointer, and the pointed-to arguments are copied when the channel is
98-
* created.
97+
* This is a non-owning pointer. If set, the pointed-to object must remain valid
98+
* until the gRPC exporter or client has been constructed.
9999
*/
100100
const grpc::ChannelArguments *channel_arguments{};
101101
};

exporters/otlp/src/otlp_grpc_client.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,6 @@ std::shared_ptr<grpc::Channel> OtlpGrpcClient::MakeChannel(const OtlpGrpcClientO
398398
void OtlpGrpcClient::PopulateChannelArguments(const OtlpGrpcClientOptions &options,
399399
grpc::ChannelArguments &grpc_arguments)
400400
{
401-
grpc_arguments = grpc::ChannelArguments{};
402-
403401
if (options.channel_arguments != nullptr)
404402
{
405403
grpc_arguments = *options.channel_arguments;

0 commit comments

Comments
 (0)