[API] Fix Logger.Enabled()

[proost]

Fixes #2667

Changes

fix to Logger.Enabled() use severity. so it changes to default behavior that enabled all logs to emit.

I fix it as minimal what original issue mentioned. But the issue reported two years ago, spec is changed.

do I need to follow "DEVELOPMENT" status spec?(https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#enabled)

I think adding features to "LoggerConfig" is correct to me(default behavior can be annoyed because all logs enabled). But this is my first time, so I don't know what is rule in this project.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: proost / name: lani_karrot (08db8f1, 0bb5bad, 1566353, 17c2424, 22c01e3, 272cc80, 34bf48f, 358c17a, 3e395c6, 4e1c190, 52589a9, 5aaab3d, 6a1d4cf, 78bfa0d, 97ebc84, 9a2530d, ec4f100, edd961b)
• ✅ login: proost / name: proost (091a649, 35b6177, 3a59302, 40c576e, 6714614, 698e834, 7138337, 7e97ad8, 813f4fe, 824fa05, 8f0e119, 962e1c6, b238ee7, b791498, be7dae0, c280e77, c48f823, ca4f1ba, e156c57, e700307, fa276f4, fb5c197)

[codecov]

Codecov Report

❌ Patch coverage is 87.67123% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.09%. Comparing base (0d35a81) to head (be7dae0).

Files with missing lines	Patch %	Lines
api/include/opentelemetry/logs/logger.h	50.00%	6 Missing ⚠️
sdk/src/logs/logger.cc	91.67%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4011      +/-   ##
==========================================
+ Coverage   82.05%   82.09%   +0.04%     
==========================================
  Files         385      385              
  Lines       15909    15989      +80     
==========================================
+ Hits        13053    13124      +71     
- Misses       2856     2865       +9     

Files with missing lines	Coverage Δ
sdk/include/opentelemetry/sdk/logs/logger_config.h	100.00% <100.00%> (ø)
sdk/include/opentelemetry/sdk/logs/processor.h	100.00% <100.00%> (ø)
sdk/src/logs/logger_config.cc	100.00% <100.00%> (ø)
sdk/src/logs/multi_log_record_processor.cc	93.25% <100.00%> (+0.82%)	⬆️
sdk/src/logs/multi_recordable.cc	90.55% <ø> (ø)
sdk/src/logs/logger.cc	89.42% <91.67%> (+1.42%)	⬆️
api/include/opentelemetry/logs/logger.h	68.86% <50.00%> (+3.99%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcalff]

do I need to follow "DEVELOPMENT" status spec?(https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#enabled)

Yes.

The spec in "development" status means some changes are still possible before it reaches a stable state.

SDK like opentelemetry-cpp needs to implement these specs early (so, now), to discover possible issues with the spec, so it can be adjusted if needed before reaching the stable status.

Thanks for the contribution.

[proost]

@marcalff @lalitb
I changed code to follow current api/sdk specs. If community is ok, can I divide fixing "EmitLogRecord" another PR? Because I think current change is meaningful and big enough.

[proost]

current code default is trace. if this is intended, I will rollback to current code.

[dbarker]

@proost Thanks for the PR! Both the LoggerConfig and YAML parsing/building features are very much needed :)

The PR has grown a bit beyond the initial issue. To facilitate review please break out the yaml config parsing to a separate PR as follow up to this one.

[marcalff]

Here, we are under sdk/include, not api/include.

It is ok to break the SDK ABI (with new data member), only the API ABI must be preserved at all costs.

Please remove OPENTELEMETRY_ABI_VERSION_NO >= 2, and have the minimum severity and trace based flag always defined in the SDK.

[proost]

Oh, I got it. 5aaab3d

Comments addressed.

[lalitb]

This looks good to me. Just to reiterate if my understanding is correct now:

• v1: The API is safe. No API ABI break. The SDK binary layout changes, so old SDK-built binaries may need a rebuild, but normal source code should not need changes.
• v2: The API intentionally includes the new Enabled() methods. The SDK also changes binary layout, but normal source code should still just recompile without code changes.

[marcalff]

LGTM, thanks for the fix.