Skip to content

[TEST] Assert overflow attribute value is boolean true#4063

Merged
marcalff merged 2 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/test-overflow-value
May 11, 2026
Merged

[TEST] Assert overflow attribute value is boolean true#4063
marcalff merged 2 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/test-overflow-value

Conversation

@cijothomas

Copy link
Copy Markdown
Member

Follow-up to #4060.

The spec says the overflow data point has exactly one attribute:
otel.metric.overflow -> bool true. Existing tests only checked the
key, so a regression in the value or its type would not be caught.
This PR adds the missing bool true assertions and pins the
precomputed kOverflowAttributes set against the spec.

Tests-only change.

@cijothomas cijothomas requested a review from a team as a code owner May 7, 2026 15:17
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (1711410) to head (2696323).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4063   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files         385      385           
  Lines       15989    15989           
=======================================
  Hits        13124    13124           
  Misses       2865     2865           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb lalitb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cijothomas - looking forward to more contributions from you ;)

@lalitb lalitb enabled auto-merge (squash) May 7, 2026 22:49
auto-merge was automatically disabled May 8, 2026 03:42

Head branch was pushed to by a user without write access

@cijothomas cijothomas force-pushed the cijothomas/test-overflow-value branch from 366898b to fade572 Compare May 8, 2026 03:42
@marcalff marcalff merged commit df5c452 into open-telemetry:main May 11, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants