[TEST] Assert overflow attribute value is boolean true#4063
Merged
marcalff merged 2 commits intoMay 11, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4063 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 385 385
Lines 15989 15989
=======================================
Hits 13124 13124
Misses 2865 2865 🚀 New features to boost your workflow:
|
lalitb
approved these changes
May 7, 2026
lalitb
left a comment
Member
There was a problem hiding this comment.
Thanks @cijothomas - looking forward to more contributions from you ;)
auto-merge was automatically disabled
May 8, 2026 03:42
Head branch was pushed to by a user without write access
366898b to
fade572
Compare
ThomsonTan
approved these changes
May 8, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4060.
The spec says the overflow data point has exactly one attribute:
otel.metric.overflow->bool true. Existing tests only checked thekey, so a regression in the value or its type would not be caught.
This PR adds the missing
bool trueassertions and pins theprecomputed
kOverflowAttributesset against the spec.Tests-only change.