implement latest semconv spec for process resource #2892

src/OpenTelemetry.Resources.Process/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+* Extended `ProcessDetector` to include `process.executable.path`,
+`process.working_directory`, `process.args_count`,`process.creation.time`,
+`process.executable.name`, `process.interactive` as well as `process.title`
+as per the latest OpenTelemetry Semantic Convention resource/entity definition.
+ ([#2971](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/3347))
+
 * Add support for .NET 10.0.
   ([#2822](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2822))
 

src/OpenTelemetry.Resources.Process/ProcessDetector.cs

@@ -1,6 +1,8 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
+using System.ComponentModel;
+
 namespace OpenTelemetry.Resources.Process;
 
 /// <summary>
@@ -14,20 +16,40 @@ internal sealed class ProcessDetector : IResourceDetector
     /// <returns>Resource with key-value pairs of resource attributes.</returns>
     public Resource Detect()
     {
-        return new Resource(new List<KeyValuePair<string, object>>(2)
+        using var currentProcess = System.Diagnostics.Process.GetCurrentProcess();
+
+        if (currentProcess.HasExited)
+        {
+            return Resource.Empty;
+        }
+
+        var attributes = new List<KeyValuePair<string, object>>(9)
         {
             new(ProcessSemanticConventions.AttributeProcessOwner, Environment.UserName),
+            new(ProcessSemanticConventions.AttributeProcessArgsCount, Environment.GetCommandLineArgs().Length),
+            new(ProcessSemanticConventions.AttributeProcessTitle, currentProcess.MainWindowTitle),
+            new(ProcessSemanticConventions.AttributeProcessWorkingDir, Environment.CurrentDirectory),
+
+            new(ProcessSemanticConventions.AttributeProcessExecName, currentProcess.ProcessName),
+            new(ProcessSemanticConventions.AttributeProcessInteractive, Environment.UserInteractive),
 #if NET
             new(ProcessSemanticConventions.AttributeProcessPid, Environment.ProcessId),
-        });
+            new(ProcessSemanticConventions.AttributeProcessExecPath, Environment.ProcessPath ?? string.Empty),
+        };
 #else
-            new(ProcessSemanticConventions.AttributeProcessPid, GetProcessPid()),
-        });
-        static int GetProcessPid()
+            new(ProcessSemanticConventions.AttributeProcessPid, currentProcess.Id),
+        };
+#endif
+
+        try
         {
-            using var process = System.Diagnostics.Process.GetCurrentProcess();
-            return process.Id;
+            attributes.Add(new(ProcessSemanticConventions.AttributeProcessStartTime, currentProcess.StartTime.ToString("O") ?? DateTime.Now.ToString("O")));
         }
-#endif
+        catch (Win32Exception)
+        {
+            attributes.Add(new(ProcessSemanticConventions.AttributeProcessStartTime, DateTime.Now.ToString("O")));
+        }
+
+        return new Resource(attributes);
     }
 }

src/OpenTelemetry.Resources.Process/ProcessSemanticConventions.cs

@@ -7,4 +7,11 @@ internal static class ProcessSemanticConventions
 {
     public const string AttributeProcessOwner = "process.owner";
     public const string AttributeProcessPid = "process.pid";
+    public const string AttributeProcessExecPath = "process.executable.path";
+    public const string AttributeProcessWorkingDir = "process.working_directory";
+    public const string AttributeProcessArgsCount = "process.args_count";
+    public const string AttributeProcessStartTime = "process.creation.time";
+    public const string AttributeProcessExecName = "process.executable.name";
+    public const string AttributeProcessInteractive = "process.interactive";
+    public const string AttributeProcessTitle = "process.title";
 }

src/OpenTelemetry.Resources.Process/README.md

@@ -53,7 +53,9 @@ using var loggerFactory = LoggerFactory.Create(builder =>
 The resource detectors will record the following metadata based on where
 your application is running:
 
-- **ProcessDetector**: `process.owner`, `process.pid`.
+- **ProcessDetector**: `process.owner`, `process.pid`, `process.executable.path`,
+`process.working_directory`, `process.args_count`,`process.creation.time`,
+`process.executable.name`, `process.interactive`, `process.title`.
 
 ## References
 

test/OpenTelemetry.Resources.Process.Tests/ProcessDetectorTests.cs

@@ -13,10 +13,23 @@ public void TestProcessAttributes()
         var resource = ResourceBuilder.CreateEmpty().AddProcessDetector().Build();
 
         var resourceAttributes = resource.Attributes.ToDictionary(x => x.Key, x => x.Value);
+#if NET
+        Assert.Equal(9, resourceAttributes.Count);
+#else
+        Assert.Equal(8, resourceAttributes.Count);
+#endif
 
-        Assert.Equal(2, resourceAttributes.Count);
-
+        Assert.IsType<long>(resourceAttributes[ProcessSemanticConventions.AttributeProcessArgsCount]);
+        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessExecName]);
+#if NET
+        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessExecPath]);
+#endif
+        Assert.IsType<bool>(resourceAttributes[ProcessSemanticConventions.AttributeProcessInteractive]);
         Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessOwner]);
         Assert.IsType<long>(resourceAttributes[ProcessSemanticConventions.AttributeProcessPid]);
+
+        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessStartTime]);
+        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessTitle]);
+        Assert.IsType<string>(resourceAttributes[ProcessSemanticConventions.AttributeProcessWorkingDir]);
     }
 }