-
Notifications
You must be signed in to change notification settings - Fork 357
implement latest semconv spec for process resource #2892 #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thompson-tomo
wants to merge
15
commits into
open-telemetry:main
Choose a base branch
from
thompson-tomo:feature/#2892_ImplementRecomendedProcessAttr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5bfc0cf
Add in alot more process attributes #2892
thompson-tomo 6316cca
Implementation of feedback
thompson-tomo ae97c1c
Further review feedback
thompson-tomo 44d0dd8
Add in an action method
thompson-tomo 4fede6b
Fix changelog
thompson-tomo 36b62f4
split out runtime changes
thompson-tomo 6d77f69
review feedback
thompson-tomo 415c7dc
Improve docs
thompson-tomo c714d56
Remove opt-in params
thompson-tomo 74eabc0
Update docs
thompson-tomo ae2e468
Typo fix in attribute name
thompson-tomo 7fb1252
Merge branch 'main' into feature/#2892_ImplementRecomendedProcessAttr
thompson-tomo c8d5ee1
Merge branch 'main' into feature/#2892_ImplementRecomendedProcessAttr
thompson-tomo 5bef668
Tweak error handling
thompson-tomo 247870d
Merge branch 'main' into feature/#2892_ImplementRecomendedProcessAttr
thompson-tomo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some process related properties may throw exceptions. For example, StartTime throws 3 exceptions, and there is likely no way to detect errors like
Win32Exceptionahead of time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the exceptions the only one we are interested in is win32 so have added a try catch and also exited earlier if process has exited.
The others are for scenarios we don't support ie windows 98.
The current directory does through a number of exceptions but they are for the set method which is not used.