-
Notifications
You must be signed in to change notification settings - Fork 1.2k
otlploghttp: support OTEL_EXPORTER_OTLP_LOGS_INSECURE and OTEL_EXPORTER_OTLP_INSECURE env vars #7608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…URE environments in http exporter
|
This will need a changelog entry. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7608 +/- ##
=======================================
- Coverage 86.1% 86.1% -0.1%
=======================================
Files 298 298
Lines 21675 21694 +19
=======================================
+ Hits 18676 18692 +16
- Misses 2624 2626 +2
- Partials 375 376 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not compliant with OTel Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md. The OTEL_EXPORTER_OTLP_INSECURE is documented only for OTLP/gRPC exporter. Note that otlpmetrichttp and otlptracehttp also do not support such env vars.
You would first have to propose adding such configuration to the OTel Specification.
|
🤔 Then I believe the rust impl is not following the spec. I'll have a look there first. Thx!
This doesn't seem to be the case opentelemetry-go/exporters/otlp/otlpmetric/otlpmetrichttp/internal/oconf/envconfig.go Lines 92 to 93 in dafdbf8
opentelemetry-go/exporters/otlp/otlptrace/otlptracehttp/internal/otlpconfig/envconfig.go Lines 91 to 92 in dafdbf8
So at least the Go impl is also not in compliance with the spec and is internally inconsistent. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
I created #7614 as it is better to use an GitHub issue for discussions and tracking. |
pellared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving per #7614 (comment)
|
@fd, thanks for your contribution. You can also consider updating the |
This PR applies the same changes as #5739 but for the
otlploghttppackage.Like this both
otlploggrpcandotlploghttpwork the same way.