Skip to content

Conversation

@fd
Copy link
Contributor

@fd fd commented Nov 17, 2025

This PR applies the same changes as #5739 but for the otlploghttp package.

Like this both otlploggrpc and otlploghttp work the same way.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@dmathieu
Copy link
Member

This will need a changelog entry.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.1%. Comparing base (4200d1e) to head (233afe5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporters/otlp/otlplog/otlploghttp/config.go 91.6% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7608     +/-   ##
=======================================
- Coverage   86.1%   86.1%   -0.1%     
=======================================
  Files        298     298             
  Lines      21675   21694     +19     
=======================================
+ Hits       18676   18692     +16     
- Misses      2624    2626      +2     
- Partials     375     376      +1     
Files with missing lines Coverage Δ
exporters/otlp/otlplog/otlploghttp/config.go 94.0% <91.6%> (-0.4%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not compliant with OTel Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md. The OTEL_EXPORTER_OTLP_INSECURE is documented only for OTLP/gRPC exporter. Note that otlpmetrichttp and otlptracehttp also do not support such env vars.

You would first have to propose adding such configuration to the OTel Specification.

@pellared pellared added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Nov 18, 2025
@fd
Copy link
Contributor Author

fd commented Nov 18, 2025

🤔 Then I believe the rust impl is not following the spec. I'll have a look there first.

Thx!


Note that otlpmetrichttp and otlptracehttp also do not support such env vars.

This doesn't seem to be the case

envconfig.WithBool("INSECURE", func(b bool) { opts = append(opts, withInsecure(b)) }),
envconfig.WithBool("METRICS_INSECURE", func(b bool) { opts = append(opts, withInsecure(b)) }),

envconfig.WithBool("INSECURE", func(b bool) { opts = append(opts, withInsecure(b)) }),
envconfig.WithBool("TRACES_INSECURE", func(b bool) { opts = append(opts, withInsecure(b)) }),

So at least the Go impl is also not in compliance with the spec and is internally inconsistent.

@fd fd closed this Nov 18, 2025
@fd fd reopened this Nov 18, 2025
@fd fd requested a review from pellared November 18, 2025 14:37
@pellared

This comment was marked as duplicate.

@pellared
Copy link
Member

I created #7614 as it is better to use an GitHub issue for discussions and tracking.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per #7614 (comment)

@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Nov 20, 2025
@pellared
Copy link
Member

@fd, thanks for your contribution. You can also consider updating the doc.go in otlptracehttp, otlpmetrichttp, and otlploghttp in a seperate PR (as support for these env vars are not documented).

@pellared pellared changed the title Support OTEL_EXPORTER_OTLP_LOGS_INSECURE and OTEL_EXPORTER_OTLP_INSECURE environments in http exporter otlploghttp: support OTEL_EXPORTER_OTLP_LOGS_INSECURE and OTEL_EXPORTER_OTLP_INSECURE env vars Nov 21, 2025
@pellared pellared merged commit da01323 into open-telemetry:main Nov 21, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants