Skip to content

Commit 2d4092e

Browse files
chore: Removed deprecated LoggerProvider#addLogRecordProcessor() (#2895)
1 parent b60b06e commit 2d4092e

File tree

7 files changed

+35
-41
lines changed

7 files changed

+35
-41
lines changed

packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,11 @@ describe('BaggageLogRecordProcessor with all keys', () => {
3434
});
3535

3636
it('onEmit adds current Baggage entries to a log record as attributes', () => {
37-
const loggerProvider = new LoggerProvider();
3837
const exporter = new InMemoryLogRecordExporter();
39-
loggerProvider.addLogRecordProcessor(baggageProcessor);
40-
loggerProvider.addLogRecordProcessor(
41-
new SimpleLogRecordProcessor(exporter)
42-
);
38+
const loggerProvider = new LoggerProvider({
39+
processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)],
40+
});
41+
4342
const logger = loggerProvider.getLogger('my-logger');
4443
const ctx = propagation.setBaggage(ROOT_CONTEXT, bag);
4544

@@ -75,12 +74,10 @@ describe('BaggageLogRecordProcessor startWith key filter', () => {
7574
});
7675

7776
it('onEmit adds current filtered by startWith Baggage entries to a log record as attributes', () => {
78-
const loggerProvider = new LoggerProvider();
7977
const exporter = new InMemoryLogRecordExporter();
80-
loggerProvider.addLogRecordProcessor(baggageProcessor);
81-
loggerProvider.addLogRecordProcessor(
82-
new SimpleLogRecordProcessor(exporter)
83-
);
78+
const loggerProvider = new LoggerProvider({
79+
processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)],
80+
});
8481
const logger = loggerProvider.getLogger('my-logger');
8582
const ctx = propagation.setBaggage(ROOT_CONTEXT, bag);
8683

@@ -114,12 +111,10 @@ describe('BaggageLogRecordProcessor with regex key filter', () => {
114111
});
115112

116113
it('onEmit adds current filtered by regex Baggage entries to a log record as attributes', () => {
117-
const loggerProvider = new LoggerProvider();
118114
const exporter = new InMemoryLogRecordExporter();
119-
loggerProvider.addLogRecordProcessor(baggageProcessor);
120-
loggerProvider.addLogRecordProcessor(
121-
new SimpleLogRecordProcessor(exporter)
122-
);
115+
const loggerProvider = new LoggerProvider({
116+
processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)],
117+
});
123118
const logger = loggerProvider.getLogger('my-logger');
124119
const ctx = propagation.setBaggage(ROOT_CONTEXT, bag);
125120

packages/winston-transport/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,10 @@ const winston = require('winston');
3333

3434

3535
// To start a logger, you first need to initialize the Logger provider.
36-
const loggerProvider = new LoggerProvider();
37-
// Add a processor to export log record
38-
loggerProvider.addLogRecordProcessor(
39-
new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())
40-
);
36+
// And add a processor to export log record.
37+
const loggerProvider = new LoggerProvider({
38+
processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())],
39+
});
4140
logsAPI.logs.setGlobalLoggerProvider(loggerProvider);
4241

4342
const logger = winston.createLogger({

packages/winston-transport/test/openTelemetryTransport.test.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ import * as assert from 'assert';
2424
import * as sinon from 'sinon';
2525
import { OpenTelemetryTransportV3 } from '../src';
2626

27-
const loggerProvider = new LoggerProvider();
2827
const memoryLogExporter = new InMemoryLogRecordExporter();
29-
loggerProvider.addLogRecordProcessor(
30-
new SimpleLogRecordProcessor(memoryLogExporter)
31-
);
28+
const loggerProvider = new LoggerProvider({
29+
processors: [new SimpleLogRecordProcessor(memoryLogExporter)],
30+
});
3231
logs.setGlobalLoggerProvider(loggerProvider);
3332

3433
const kMessage = 'log-message';

plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@ const tracer = tracerProvider.getTracer('default');
4949
const resource = resourceFromAttributes({
5050
[ATTR_SERVICE_NAME]: 'test-instrumentation-bunyan',
5151
});
52-
const loggerProvider = new LoggerProvider({ resource });
5352
const memExporter = new InMemoryLogRecordExporter();
54-
loggerProvider.addLogRecordProcessor(new SimpleLogRecordProcessor(memExporter));
53+
const loggerProvider = new LoggerProvider({
54+
resource,
55+
processors: [new SimpleLogRecordProcessor(memExporter)],
56+
});
5557
logs.setGlobalLoggerProvider(loggerProvider);
5658

5759
const instrumentation = new BunyanInstrumentation();

plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,11 @@ const tracer = tracerProvider.getTracer('default');
5555
const resource = resourceFromAttributes({
5656
[ATTR_SERVICE_NAME]: 'test-instrumentation-pino',
5757
});
58-
const loggerProvider = new LoggerProvider({ resource });
5958
const memExporter = new InMemoryLogRecordExporter();
60-
loggerProvider.addLogRecordProcessor(new SimpleLogRecordProcessor(memExporter));
59+
const loggerProvider = new LoggerProvider({
60+
resource,
61+
processors: [new SimpleLogRecordProcessor(memExporter)],
62+
});
6163
logs.setGlobalLoggerProvider(loggerProvider);
6264

6365
const instrumentation = new PinoInstrumentation();

plugins/node/opentelemetry-instrumentation-winston/README.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@ const tracerProvider = new NodeTracerProvider();
3838
tracerProvider.register();
3939

4040
// To start a logger, you first need to initialize the Logger provider.
41-
const loggerProvider = new LoggerProvider();
42-
// Add a processor to export log record
43-
loggerProvider.addLogRecordProcessor(
44-
new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())
45-
);
41+
// Add a processor to export log record.
42+
const loggerProvider = new LoggerProvider({
43+
processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())],
44+
});
4645
logsAPI.logs.setGlobalLoggerProvider(loggerProvider);
4746

4847
registerInstrumentations({
@@ -122,11 +121,10 @@ const winston = require('winston');
122121

123122

124123
// To start a logger, you first need to initialize the Logger provider.
125-
const loggerProvider = new LoggerProvider();
126124
// Add a processor to export log record
127-
loggerProvider.addLogRecordProcessor(
128-
new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())
129-
);
125+
const loggerProvider = new LoggerProvider({
126+
processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())],
127+
});
130128
logsAPI.logs.setGlobalLoggerProvider(loggerProvider);
131129

132130
const logger = winston.createLogger({

plugins/node/opentelemetry-instrumentation-winston/test/winston.test.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,10 @@ const provider = new NodeTracerProvider({
4141
const tracer = provider.getTracer('default');
4242
context.setGlobalContextManager(new AsyncLocalStorageContextManager());
4343

44-
const loggerProvider = new LoggerProvider();
4544
const memoryLogExporter = new InMemoryLogRecordExporter();
46-
loggerProvider.addLogRecordProcessor(
47-
new SimpleLogRecordProcessor(memoryLogExporter)
48-
);
45+
const loggerProvider = new LoggerProvider({
46+
processors: [new SimpleLogRecordProcessor(memoryLogExporter)],
47+
});
4948
logs.setGlobalLoggerProvider(loggerProvider);
5049

5150
const kMessage = 'log-message';

0 commit comments

Comments
 (0)