feat(aws-sdk): add exception hook #2398
Conversation
project0
force-pushed
the
feat/aws-sdk-exception
branch
3 times, most recently
from
dd9b3b3 to
117d248
Compare
project0
force-pushed
the
feat/aws-sdk-exception
branch
from
117d248 to
8de2ca6
Compare
project0
force-pushed
the
feat/aws-sdk-exception
branch
from
8de2ca6 to
8fe1574
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 90.80% 90.80% -0.01%
==========================================
Files 169 169
Lines 8026 8036 +10
Branches 1635 1637 +2
==========================================
+ Hits 7288 7297 +9
- Misses 738 739 +1
|
project0
force-pushed
the
feat/aws-sdk-exception
branch
from
8fe1574 to
29b9dd2
Compare
|
@jj22ee can you please take a look at this? I know it was opened before you were made a component owner but it's been sitting for quite a while. |
|
I think this feature looks reasonable. The package already has similar hooks defined and it is well documented/tested. If it gets rebased I think we can move forward with it. @jj22ee please comment if you disagree otherwise this will get my 👍 |
|
Hey, sorry for not taking a look at this, thanks @dyladan for the ping. @project0 I suppose this solves #1765 indirectly for you because this allows you to update Span status or unrecord the Span exception via the new |
| @@ -53,6 +53,7 @@ aws-sdk instrumentation has few options available to choose from. You can set th | |||
| | ----------------------------------------- | ----------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | `preRequestHook` | `AwsSdkRequestCustomAttributeFunction` | Hook called before request send, which allow to add custom attributes to span. | | |||
| | `responseHook` | `AwsSdkResponseCustomAttributeFunction` | Hook for adding custom attributes when response is received from aws. | | |||
| | `exceptionHook` | `AwsSdkExceptionCustomAttributeFunction` | Hook for adding custom attributes when exception is received from aws. | | |||
There was a problem hiding this comment.
| | `exceptionHook` | `AwsSdkExceptionCustomAttributeFunction` | Hook for adding custom attributes when exception is received from aws. | | |
| | `exceptionHook` | `AwsSdkExceptionCustomAttributeFunction` | Hook for adding custom attributes when exception is received from aws. | |
| ); | ||
| span.setAttribute('error.from.exception.hook', err.name); | ||
| }, | ||
|
|
|
Please resolve the conflicts and we can get this merged |
Which problem is this PR solving?
Short description of the changes