ci: Add Github action to add "has:owner-approval" label for approved PRs #2798
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
==========================================
+ Coverage 89.69% 89.74% +0.04%
==========================================
Files 186 186
Lines 9048 9048
Branches 1855 1855
==========================================
+ Hits 8116 8120 +4
+ Misses 932 928 -4 🚀 New features to boost your workflow:
|
hectorhdzg
changed the title
pichlermarc
reviewed
May 21, 2025
Comment on lines
+3
to
+6
| on: | ||
| pull_request_review: | ||
| types: | ||
| - submitted |
There was a problem hiding this comment.
Hmm, I think that the pull_request_review trigger only provides a read-only GITHUB_TOKEN - I guess it would not be able to re-label the PR in that case, right? 🤔
Thinking more about it, I'm also wondering if there are some security concerns if we were to give the workflow additional permissions. 🤔
There was a problem hiding this comment.
We can add permissions by workflow right? that would prevent us to change the default permissions and keep them read only for other workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Automate label tagging for owner reviews in PRs
Short description of the changes
Added scripts to parse component_owners.yml, to get existing components and owners by componer
Added script to get details about a PR, looks for all updated files and determine if one of the owner of that file already approved the PR, then add label.
Added workflow to kick off the script when a PR is reviewed and approved.