Skip to content

feat(instrumentation-hapi): support migration to stable HTTP semconv, v1.23.1 #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trentm
Copy link
Contributor

@trentm trentm commented May 28, 2025

instrumentation-hapi, in addition to providing the HTTP route for the
HTTP instrumentation, also generates hapi spans for each plugin/route.
Attributes on these hapi spans include some covered by HTTP semantic
conventions.

This change adds support for controlled migration from the old to the
stable HTTP semconv via the OTEL_SEMCONV_STABILITY_OPT_IN envvar. See
https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/

This also updates from the deprecated SpanAttributes api type to
Attributes.

Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv)
Refs: open-telemetry/opentelemetry-js#4175 (Attributes)

… v1.23.1

`instrumentation-hapi`, in addition to providing the HTTP route for the
*HTTP* instrumentation, also generates hapi spans for each plugin/route.
Attributes on these hapi spans include some covered by HTTP semantic
conventions.

This change adds support for controlled migration from the old to the
stable HTTP semconv via the `OTEL_SEMCONV_STABILITY_OPT_IN` envvar. See
https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/

This also updates from the deprecated `SpanAttributes` api type to
`Attributes`.

Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv)
Refs: open-telemetry/opentelemetry-js#4175 (Attributes)
@trentm trentm self-assigned this May 28, 2025
@trentm trentm requested a review from a team as a code owner May 28, 2025 19:34
@github-actions github-actions bot added the pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. label May 28, 2025
@trentm
Copy link
Contributor Author

trentm commented May 28, 2025

This also handles #2377 for instrumentation-hapi.

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.69%. Comparing base (7481f71) to head (44c6f88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...de/opentelemetry-instrumentation-hapi/src/utils.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2863   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         185      186    +1     
  Lines        9034     9048   +14     
  Branches     1852     1855    +3     
=======================================
+ Hits         8103     8116   +13     
- Misses        931      932    +1     
Files with missing lines Coverage Δ
...emetry-instrumentation-hapi/src/instrumentation.ts 99.32% <100.00%> (+<0.01%) ⬆️
.../opentelemetry-instrumentation-hapi/src/semconv.ts 100.00% <100.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/utils.ts 98.21% <92.85%> (-1.79%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@trentm trentm added the has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions label May 30, 2025
@trentm trentm requested a review from JacksonWeber May 30, 2025 17:29
@trentm trentm enabled auto-merge (squash) June 2, 2025 21:18
@trentm trentm merged commit 2317e2f into open-telemetry:main Jun 2, 2025
23 checks passed
@dyladan dyladan mentioned this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-hapi pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants