-
Notifications
You must be signed in to change notification settings - Fork 580
feat(instrumentation-hapi): support migration to stable HTTP semconv, v1.23.1 #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-hapi): support migration to stable HTTP semconv, v1.23.1 #2863
Conversation
… v1.23.1 `instrumentation-hapi`, in addition to providing the HTTP route for the *HTTP* instrumentation, also generates hapi spans for each plugin/route. Attributes on these hapi spans include some covered by HTTP semantic conventions. This change adds support for controlled migration from the old to the stable HTTP semconv via the `OTEL_SEMCONV_STABILITY_OPT_IN` envvar. See https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/ This also updates from the deprecated `SpanAttributes` api type to `Attributes`. Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv) Refs: open-telemetry/opentelemetry-js#4175 (Attributes)
This also handles #2377 for instrumentation-hapi. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 185 186 +1
Lines 9034 9048 +14
Branches 1852 1855 +3
=======================================
+ Hits 8103 8116 +13
- Misses 931 932 +1
🚀 New features to boost your workflow:
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
instrumentation-hapi
, in addition to providing the HTTP route for theHTTP instrumentation, also generates hapi spans for each plugin/route.
Attributes on these hapi spans include some covered by HTTP semantic
conventions.
This change adds support for controlled migration from the old to the
stable HTTP semconv via the
OTEL_SEMCONV_STABILITY_OPT_IN
envvar. Seehttps://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/
This also updates from the deprecated
SpanAttributes
api type toAttributes
.Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv)
Refs: open-telemetry/opentelemetry-js#4175 (Attributes)