-
Notifications
You must be signed in to change notification settings - Fork 587
chore: rename workspace dirs to packages/${package-base-name} (extreme edition) #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e edition) This PR is the final take of the plan discussed at open-telemetry#2223. This implements option 3 of open-telemetry#2223 (comment) (i.e. the "extreme" option). Before this change the packages published from this repo were spread across these workspace dirs: "packages/*", "plugins/node/*", "plugins/web/*", "propagators/*", "detectors/node/*", "metapackages/*" with the directory name *usually* matching the npm package name, and with or without a leading "opentelemetry-". This PR normalizes all dirs to be under "packages/*" and to have the base dir match the package name (excluding the npm `@opentelemetry/` org prefix). Refs: open-telemetry#2223
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that some packages have a change in this file but others, like this one, appears as a new file when it already existed in the previous location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that may be due to there being a number of "tsconfig.json" files with the same (or mostly similar) content that git
couldn't reasonably disambiguate which file moved to where, so it gives up and just categorizes them as independent "deletes" and "creates".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: now that the plugins
folder is gone I wonder if we should keep the word in the keywords list. Also there is such word in some instrumentations. I think we could be more specific in the keywords section of each package. I can create an issue with a proposal and discuss it in the next SIG meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that the plugins folder is gone I wonder if we should keep the word in the keywords list. Also there is such word in some instrumentations.
Yep, the plugin
label can be removed for sure - it was the name for instrumentation
from way back in the day.
I think we could be more specific in the keywords section of each package. I can create an issue with a proposal and discuss it in the next SIG meeting
Agree, there's the profiling
keyword everywhere. A proposal to clean this up would be appreciated. :)
These links changed with the repo dir moves in open-telemetry/opentelemetry-js-contrib#2928
The links to opentelemetry-js-contrib.git changed due to open-telemetry/opentelemetry-js-contrib#2928
The links to opentelemetry-js-contrib.git changed due to open-telemetry/opentelemetry-js-contrib#2928
Follow up of package/folder renames from open-telemetry/opentelemetry-js-contrib#2928 Failing pipeline https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5094725&view=results
This PR is the final take of the plan discussed at #2223.
This implements option 3 of #2223 (comment)
(i.e. the "extreme" option).
Before this change the packages published from this repo were spread
across these workspace dirs:
with the directory name usually matching the npm package name, and
with or without a leading "opentelemetry-". This PR normalizes all dirs
to be under "packages/*" and to have the base dir match the package
name (excluding the npm
@opentelemetry/
org prefix).Obsoletes: #2223
Obsoletes: #2920