Skip to content

chore: rename workspace dirs to packages/${package-base-name} (extreme edition) #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jul 7, 2025

This PR is the final take of the plan discussed at #2223.
This implements option 3 of #2223 (comment)
(i.e. the "extreme" option).

Before this change the packages published from this repo were spread
across these workspace dirs:

"packages/*",
"plugins/node/*",
"plugins/web/*",
"propagators/*",
"detectors/node/*",
"metapackages/*"

with the directory name usually matching the npm package name, and
with or without a leading "opentelemetry-". This PR normalizes all dirs
to be under "packages/*" and to have the base dir match the package
name (excluding the npm @opentelemetry/ org prefix).

Obsoletes: #2223
Obsoletes: #2920

…e edition)

This PR is the final take of the plan discussed at open-telemetry#2223.
This implements option 3 of open-telemetry#2223 (comment)
(i.e. the "extreme" option).

Before this change the packages published from this repo were spread
across these workspace dirs:

    "packages/*",
    "plugins/node/*",
    "plugins/web/*",
    "propagators/*",
    "detectors/node/*",
    "metapackages/*"

with the directory name *usually* matching the npm package name, and
with or without a leading "opentelemetry-". This PR normalizes all dirs
to be under "packages/*" and to have the base dir match the package
name (excluding the npm `@opentelemetry/` org prefix).

Refs: open-telemetry#2223
@trentm trentm requested a review from a team as a code owner July 7, 2025 21:05
Copy link
Contributor

github-actions bot commented Jul 8, 2025

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@pichlermarc pichlermarc added has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions and removed pkg-status:unmaintained:autoclose-scheduled labels Jul 8, 2025
Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that some packages have a change in this file but others, like this one, appears as a new file when it already existed in the previous location.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that may be due to there being a number of "tsconfig.json" files with the same (or mostly similar) content that git couldn't reasonably disambiguate which file moved to where, so it gives up and just categorizes them as independent "deletes" and "creates".

Copy link
Contributor

@david-luna david-luna Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: now that the plugins folder is gone I wonder if we should keep the word in the keywords list. Also there is such word in some instrumentations. I think we could be more specific in the keywords section of each package. I can create an issue with a proposal and discuss it in the next SIG meeting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that the plugins folder is gone I wonder if we should keep the word in the keywords list. Also there is such word in some instrumentations.

Yep, the plugin label can be removed for sure - it was the name for instrumentation from way back in the day.

I think we could be more specific in the keywords section of each package. I can create an issue with a proposal and discuss it in the next SIG meeting

Agree, there's the profiling keyword everywhere. A proposal to clean this up would be appreciated. :)

@trentm trentm merged commit 17f4334 into open-telemetry:main Jul 8, 2025
46 of 47 checks passed
@trentm trentm deleted the trentm-all-your-dir-3 branch July 8, 2025 15:21
trentm added a commit to trentm/opentelemetry.io that referenced this pull request Jul 9, 2025
trentm added a commit to trentm/opentelemetry.io that referenced this pull request Jul 9, 2025
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this pull request Jul 11, 2025
trentm added a commit to trentm/opentelemetry-lambda that referenced this pull request Jul 14, 2025
The links to opentelemetry-js-contrib.git changed due to
open-telemetry/opentelemetry-js-contrib#2928
tylerbenson pushed a commit to open-telemetry/opentelemetry-lambda that referenced this pull request Jul 14, 2025
The links to opentelemetry-js-contrib.git changed due to
open-telemetry/opentelemetry-js-contrib#2928
HarshaNalluru added a commit to HarshaNalluru/azure-sdk-for-js that referenced this pull request Jul 16, 2025
hectorhdzg pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.