Skip to content

chore: add testing with Node.js 23 #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jan 30, 2025

This was challenging because Node.js v23.6.0 enabled type-stripping
by default, which means node will attempt to execute .ts files by default.
This is incompatible with the .ts handling being used for running
tests (which was indirectly using ts-node for this via .mocharc.yml).

Instead, tests are now run by first compiling the test/** typescript
files to build/test/**, then executing them from there. This
required updating some relative paths to test files that were
not compiled (like .js fixtures, etc.).

Note: I didn't need to change any runtime code.

Refs: #5415 (this is option 1)

This was challenging because Node.js v23.6.0 enabled type-stripping
by default, which means node will attempt to execute .ts files by default.
This is incompatible with the .ts handling being used for running
tests (which was indirectly using ts-node for this via .mocharc.yml).

Instead, tests are now run by first compiling the test/** typescript
files to build/test/**, then executing them from there. This
required updating some relative paths to test files that were
not compiled (like .js fixtures, etc.).
@trentm trentm self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f9fda8b) to head (c40ef8c).
Report is 103 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f9fda8b) and HEAD (c40ef8c). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f9fda8b) HEAD (c40ef8c)
10 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5410       +/-   ##
==========================================
- Coverage   94.65%   0.00%   -94.66%     
==========================================
  Files         317      23      -294     
  Lines        8025      40     -7985     
  Branches     1687       3     -1684     
==========================================
- Hits         7596       0     -7596     
+ Misses        429      40      -389     

see 305 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Apr 14, 2025
@github-actions github-actions bot removed the stale label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant