Skip to content

refactor!: convert all SDK timestamps from HrTime to bigint #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dyladan wants to merge 29 commits into from

Lint

3f01070
Select commit
Loading
Failed to load commit list.
Closed

refactor!: convert all SDK timestamps from HrTime to bigint #5522

Lint
3f01070
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2025 in 0s

94.76% (-0.19%) compared to e947bd9

View this Pull Request on Codecov

94.76% (-0.19%) compared to e947bd9

Details

Codecov Report

Attention: Patch coverage is 86.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (e947bd9) to head (3f01070).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
packages/opentelemetry-sdk-trace-base/src/Span.ts 72.00% 7 Missing ⚠️
experimental/packages/sdk-logs/src/LogRecord.ts 42.85% 4 Missing ⚠️
packages/opentelemetry-core/src/common/time.ts 90.90% 2 Missing ⚠️
...sdk-metrics/src/aggregator/ExponentialHistogram.ts 75.00% 2 Missing ⚠️
...l/packages/shim-opencensus/src/metric-transform.ts 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5522      +/-   ##
==========================================
- Coverage   94.95%   94.76%   -0.19%     
==========================================
  Files         308      307       -1     
  Lines        7927     7927              
  Branches     1604     1608       +4     
==========================================
- Hits         7527     7512      -15     
- Misses        400      415      +15
Files with missing lines Coverage Δ
...ry-exporter-prometheus/src/PrometheusSerializer.ts 96.10% <100.00%> (ø)
...ntal/packages/otlp-transformer/src/common/utils.ts 88.88% <100.00%> (-11.12%) ⬇️
...tal/packages/otlp-transformer/src/logs/internal.ts 100.00% <ø> (ø)
.../packages/otlp-transformer/src/metrics/internal.ts 100.00% <ø> (ø)
...al/packages/otlp-transformer/src/trace/internal.ts 98.41% <ø> (ø)
...es/sdk-logs/src/export/ConsoleLogRecordExporter.ts 83.33% <ø> (-1.29%) ⬇️
...ges/opentelemetry-exporter-jaeger/src/transform.ts 93.33% <100.00%> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 90.90% <100.00%> (ø)
...y-sdk-trace-base/src/export/ConsoleSpanExporter.ts 81.25% <100.00%> (ø)
packages/sdk-metrics/src/Instruments.ts 96.00% <100.00%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov