fix: remove debug logs and use the diag logger for init timings #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Jun 11, 2025
| @@ -610,7 +610,9 @@ export async function init() { | |||
| initialized = true; | |||
| } | |||
|
|
|||
| console.log('Registering OpenTelemetry'); | |||
| export function logDebug(message: string, ...args: unknown[]) { | |||
| diag.debug(message, ...args); | |||
There was a problem hiding this comment.
Any reason this needs to be a separate function rather than calling debug directly from the callers?
There was a problem hiding this comment.
When everything is bundled, any OTEL module (including diag) is not directly available to the outside of wrapper. It can be solved by configuring webpack to bundle diag out individually, but it will just complicate the things. So, I think, it is better to have init.mjs handling the things over wrapper instead of having directt dependency.
serkan-ozal
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during the SIG meeting, let's remove the
Registering OpenTelemetrylog as this is showing in plain text (not JSON formatted)see picture below:
The init duration information can definitely be useful so I propose to use the diag logger and set the level to
DEBUG. This way a customer usingINFOlog, won't see any plain text logs.