-
Notifications
You must be signed in to change notification settings - Fork 204
Add Instana Propagator: Instana Propagator Extension #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Instana Propagator: Instana Propagator Extension #1582
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
This looks like a good start - there are a few CI issues to fix (you can run all these checks locally, check out developer/contributing documentation) |
@brettmc , I have fixed the CI issues locally and hoping it will be fine in CI too, But I don't see CI checks gets triggered for the PR.
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This propagator must not be maintained in this repository, see Propagators Distribution:
Additional
Propagator
s implementing vendor-specific protocols such as AWS
X-Ray trace header protocol MUST NOT be maintained or distributed as part of
the Core OpenTelemetry repositories.
…n to account by getter.
@Nevay , I understand that vendor-specific propagators are not maintained by the core opentelemetry-php maintainers. However, I noticed that the opentelemetry-js-contrib repository hosts an Instana propagator for Node.js, which inspired the idea to host the Instana propagator for PHP here as well. That said, I’m happy to volunteer myself and my colleague as maintainers for this extension. Since @brettmc expressed support for contributing the Instana propagator to this repository, I’ve gone ahead and submitted a PR. Looking forward to your thoughts or suggestions. |
The referenced contrib repo is https://github.com/open-telemetry/opentelemetry-php-contrib. This PR is currently against the PHP Core repo, https://github.com/open-telemetry/opentelemetry-php and should thus be ported to contrib. |
Thanks @ChrisLightfootWild for suggestion. I agree this extension should be ported to opentelemetry-php-contrib. I'll move this PR there. |
Opened the PR under opentelemetry-php-contrib repo and Hence closing this one. |
Which problem is this PR solving?
This PR adds a vendor specific propagator for the vendor specific trace correlation headers used by Instana.
Short description of the changes
Add Instana propagator plus unit tests.