-
Couldn't load subscription status.
- Fork 296
Exclude buf.yaml from release archives via .gitattributes (#604) #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Exclude buf.yaml from release archives via .gitattributes (#604) #721
Conversation
|
|
|
Please consider adding |
|
@tigrannajaryan, sorry I am new to this. Are there specific reviewers or groups I need to ask for reviews ? |
|
@open-telemetry/specs-sponsors @open-telemetry/technical-committee please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there actually a need to remove this file? Does it create any problems?
It's part of the validation and code-generation and we ship proto files as they are in the archive. We expect consumers of the release to generate code. In a generic case, without this file, consumers might not be able to generate code from the proto we provide.
Adds an export-ignore rule for buf.yaml to prevent it from appearing in GitHub release
tarballs and zip files.
Background:
buf.yaml to appear in the tarball.
Closes #604