profiles: improve Sample message clarity and usage documentation. #724
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
|
@open-telemetry/profiling-maintainers as discussed in the SIG meeting, this replaces #714, retaining the straightforward/agreed bits but removing/deferring the aggregation doc changes until further discussion. |
aalexand
approved these changes
Oct 8, 2025
felixge
reviewed
Oct 16, 2025
|
We also discussed in one of the SIG meetings that we should document that the "shape" of the samples in terms of values vs timestamps should be the same for all samples in the given profile. For example, we disallow having one sample with timestamps and another a timestamp-less aggregated value sample. Do we want to add that note here or in a separate PR? |
florianl
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.