profiles: drop profile.comment_strindices #729
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up as open-telemetry/semantic-conventions#2861 go merged. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
profiles-comment_strindices
branch
from
034b37a to
ade7f99
Compare
|
@open-telemetry/profiling-approvers |
christos68k
approved these changes
Oct 22, 2025
aalexand
approved these changes
Oct 22, 2025
lmolkova
reviewed
Oct 28, 2025
| // in this field as not equal, even if they represented the same object at an earlier | ||
| // time. | ||
| // This field is optional; an ID may be assigned to an ID-less profile in a later step. | ||
| bytes profile_id = 8; |
There was a problem hiding this comment.
we're still in development status, so it's not that important, but I believe we should not update the indices of existing fields - https://protobuf.dev/programming-guides/proto3/#deleting
There was a problem hiding this comment.
We've been doing this a few times as we agreed we'll do this before we go to alpha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up as open-telemetry/semantic-conventions#2861 got merged.