mysqlclient instrumentor: improved keyword argument handling (#2894) #3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
instrumentation/opentelemetry-instrumentation-mysqlclient/tests/test_mysqlclient_integration.py
Show resolved
Hide resolved
florianschieder
force-pushed
the
wrap-connect-kwargs
branch
from
dc23076 to
fa91e41
Compare
instrumentation/opentelemetry-instrumentation-mysqlclient/tests/test_mysqlclient_integration.py
Outdated
Show resolved
Hide resolved
florianschieder
force-pushed
the
wrap-connect-kwargs
branch
from
fa91e41 to
362bd17
Compare
…lemetry#2894) - forward "all" keyword arguments to wrap_connect() - keep defaults as defined previously
florianschieder
force-pushed
the
wrap-connect-kwargs
branch
from
226e4c9 to
afdc78e
Compare
Author
|
Rebased onto upstream |
tammy-baylis-swi
approved these changes
Nov 19, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Many thanks for the constructive exchange and review suggestions :-)
Thanks for walking through things! Lgtm, the Maintainers will also have a look.
xrmx
reviewed
Nov 20, 2025
| "enable_commenter": False, | ||
| "commenter_options": {}, | ||
| "enable_attribute_commenter": False, | ||
| **kwargs, |
Contributor
There was a problem hiding this comment.
What do you think on having an utility function that extracts from kwargs whatever wrap_connect supports instead? I think it'll become harder to reason about code that just forwards everything it gets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements forwarding "all" keyword arguments to
wrap_connect(), our concrete use case is the one as described in #2894. Defaults are kept as defined previously.Fixes #2894 (issue)
Type of change
How Has This Been Tested?
tox -e test-instrumentation-mysqlclienttox -e lint-instrumentation-mysqlclienttox -e precommitDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.