fix: Update PsycopgInstrumentor.instrument_connection to use async cursor factory
#3956
+59
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
PsycopgInstrumentor.instrument_connectionto support both sync and asyncpsycopgconnections by configuring the appropriatecursor_factory.Previously,
instrument_connectionalways used the sync cursor factory and did not properly handleAsyncConnectioninstances. As a result, calls made through an async connection would fail because of the async context.With this change:
connectionis apsycopg.AsyncConnection, we setconnection.cursor_factoryto_new_cursor_async_factory(...).connection.cursor_factoryto_new_cursor_factory(...).This aligns
instrument_connectionwith the behavior of the globalinstrument()helper and ensures both sync and async connections are correctly traced.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The tests in the
psycopginstrumentation test suite to already cover both sync and async connections.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.