opentelemetry-instrumentation-aiohttp-client: update instrumentor to respect http instrumentation suppression #3957
+52
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herin049
changed the title
herin049
commented
Nov 18, 2025
|
|
||
| # pylint:disable=unused-argument | ||
| def instrumented_init(wrapped, instance, args, kwargs): | ||
| if not is_instrumentation_enabled(): |
Contributor
Author
There was a problem hiding this comment.
I opted to remove this check since I don't get its purpose. In addition, it could lead to unexpected behavior if the user creates a ClientSession object with instrumentation disabled and then subsequently re-enables instrumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where the
opentelemetry-instrumentation-aiohttp-clientlibrary does not respect thesuppress_http_instrumentation()context manager.Fixes #3953
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test cases have been updated to test suppression using
suppress_http_instrumentation()in addition tosuppress_instrumentation()Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.