Code cleanup, removed the InMemoryMetricExporter, updated tests

Author: nstawski

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py

@@ -21,7 +21,7 @@
 from sys import stdout
 from threading import Event, Lock, RLock, Thread
 from time import time_ns
-from typing import IO, Callable, Dict, Iterable, Optional, Sequence
+from typing import IO, Callable, Dict, Iterable, Optional
 
 from typing_extensions import final
 
@@ -58,7 +58,7 @@
     _ObservableUpDownCounter,
     _UpDownCounter,
 )
-from opentelemetry.sdk.metrics._internal.point import MetricsData, Metric
+from opentelemetry.sdk.metrics._internal.point import MetricsData
 from opentelemetry.util._once import Once
 
 _logger = getLogger(__name__)
@@ -173,29 +173,6 @@ def force_flush(self, timeout_millis: float = 10_000) -> bool:
         return True
 
 
-class InMemoryMetricExporter(MetricExporter):
-    def __init__(self):
-        super().__init__()
-        self.metrics = {}
-        self._counter = 0
-
-    def export(
-        self,
-        metrics: Sequence[Metric],
-        timeout_millis: float = 10_000,
-        **kwargs,
-    ) -> MetricExportResult:
-        self.metrics[self._counter] = metrics
-        self._counter += 1
-        return MetricExportResult.SUCCESS
-
-    def shutdown(self, timeout_millis: float = 30_000, **kwargs) -> None:
-        pass
-
-    def force_flush(self, timeout_millis: float = 10_000) -> bool:
-        return True
-
-
 class MetricReader(ABC):
     # pylint: disable=too-many-branches,broad-exception-raised
     """
@@ -588,3 +565,4 @@ def force_flush(self, timeout_millis: float = 10_000) -> bool:
         super().force_flush(timeout_millis=timeout_millis)
         self._exporter.force_flush(timeout_millis=timeout_millis)
         return True
+    

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py

@@ -17,7 +17,6 @@
     AggregationTemporality,
     ConsoleMetricExporter,
     InMemoryMetricReader,
-    InMemoryMetricExporter,
     MetricExporter,
     MetricExportResult,
     MetricReader,
@@ -46,7 +45,6 @@
     "AggregationTemporality",
     "Buckets",
     "ConsoleMetricExporter",
-    "InMemoryMetricExporter",
     "InMemoryMetricReader",
     "MetricExporter",
     "MetricExportResult",

opentelemetry-sdk/tests/metrics/test_in_memory_metric_exporter.py

@@ -5,15 +5,13 @@
 from opentelemetry.sdk.metrics import MeterProvider
 
 from opentelemetry.sdk.metrics.export import (
-    InMemoryMetricExporter,
-    PeriodicExportingMetricReader,
+    InMemoryMetricReader,
 )
 
 class TestMetricCardinalityLimit(TestCase):
 
     def setUp(self):
-        self.exporter = InMemoryMetricExporter()
-        self.reader = PeriodicExportingMetricReader(exporter=self.exporter, export_interval_millis=500)
+        self.reader = InMemoryMetricReader()
         self.meter_provider = MeterProvider(metric_readers=[self.reader])
         self.meter = self.meter_provider.get_meter("test_meter")
 
@@ -30,7 +28,7 @@ def test_metric_cardinality_limit(self):
         self.reader.force_flush()
 
         # Retrieve the metrics from the in-memory exporter
-        metric_data = self.exporter.metrics
+        metric_data = self.reader.get_metrics_data()
 
         # Check if the length of the metric data doesn't exceed 2000
         self.assertTrue(len(metric_data) <= 2000)

opentelemetry-sdk/tests/metrics/test_metric_cardinality_limit.py

@@ -36,7 +36,6 @@
 )
 from opentelemetry.sdk.metrics._internal import SynchronousMeasurementConsumer
 from opentelemetry.sdk.metrics.export import (
-    InMemoryMetricExporter,
     Metric,
     MetricExportResult,
     MetricReader,