Skip to content

Commit 1309205

Browse files
authored
fix: update IL attribute naming convention to match spec (#428)
1 parent 5386592 commit 1309205

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

exporter/jaeger/lib/opentelemetry/exporter/jaeger/encoder.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ def encoded_instrumentation_library(instrumentation_library)
134134
return EMPTY_ARRAY unless instrumentation_library
135135

136136
tags = []
137-
tags << encoded_tag('otel.instrumentation_library.name', instrumentation_library.name) if instrumentation_library.name
138-
tags << encoded_tag('otel.instrumentation_library.version', instrumentation_library.version) if instrumentation_library.version
137+
tags << encoded_tag('otel.library.name', instrumentation_library.name) if instrumentation_library.name
138+
tags << encoded_tag('otel.library.version', instrumentation_library.version) if instrumentation_library.version
139139
tags
140140
end
141141

exporter/jaeger/test/opentelemetry/exporters/jaeger/encoder_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,10 @@
9595

9696
name_tag, version_tag = encoded_span.tags
9797

98-
_(name_tag.key).must_equal('otel.instrumentation_library.name')
98+
_(name_tag.key).must_equal('otel.library.name')
9999
_(name_tag.vStr).must_equal('mylib')
100100

101-
_(version_tag.key).must_equal('otel.instrumentation_library.version')
101+
_(version_tag.key).must_equal('otel.library.version')
102102
_(version_tag.vStr).must_equal('0.1.0')
103103
end
104104

@@ -111,7 +111,7 @@
111111

112112
name_tag, = encoded_span.tags
113113

114-
_(name_tag.key).must_equal('otel.instrumentation_library.name')
114+
_(name_tag.key).must_equal('otel.library.name')
115115
_(name_tag.vStr).must_equal('mylib')
116116
end
117117
end

0 commit comments

Comments
 (0)