Skip to content

Commit 968e8ea

Browse files
authored
fix: OTLP parent_span_id should be nil for root (#429)
1 parent 1309205 commit 968e8ea

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

exporter/otlp/lib/opentelemetry/exporter/otlp/exporter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def as_otlp_span(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLen
215215
trace_id: span_data.trace_id,
216216
span_id: span_data.span_id,
217217
trace_state: span_data.tracestate,
218-
parent_span_id: span_data.parent_span_id,
218+
parent_span_id: span_data.parent_span_id == OpenTelemetry::Trace::INVALID_SPAN_ID ? nil : span_data.parent_span_id,
219219
name: span_data.name,
220220
kind: as_otlp_span_kind(span_data.kind),
221221
start_time_unix_nano: as_otlp_timestamp(span_data.start_timestamp),

exporter/otlp/lib/opentelemetry/exporter/otlp/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module OpenTelemetry
88
module Exporter
99
module OTLP
1010
## Current OpenTelemetry OTLP exporter version
11-
VERSION = '0.6.0'
11+
VERSION = '0.6.1'
1212
end
1313
end
1414
end

exporter/otlp/test/opentelemetry/exporter/otlp/exporter_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
Opentelemetry::Proto::Trace::V1::Span.new(
193193
trace_id: trace_id,
194194
span_id: root_span_id,
195-
parent_span_id: OpenTelemetry::Trace::INVALID_SPAN_ID,
195+
parent_span_id: nil,
196196
name: 'root',
197197
kind: Opentelemetry::Proto::Trace::V1::Span::SpanKind::INTERNAL,
198198
start_time_unix_nano: (start_timestamp.to_r * 1_000_000_000).to_i,

0 commit comments

Comments
 (0)