Skip to content

Conversation

@schmikei
Copy link

Adds a new blog post around our work in upstreaming unroll

Fixes: #8039

@otelbot-docs otelbot-docs bot requested a review from a team October 14, 2025 20:08
@github-actions github-actions bot added the blog label Oct 14, 2025
@schmikei schmikei marked this pull request as ready for review October 14, 2025 20:12
@schmikei schmikei requested a review from a team as a code owner October 14, 2025 20:12
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for committing this PR, some initial feedback.

@svrnm
Copy link
Member

svrnm commented Oct 15, 2025

@open-telemetry/collector-approvers PTAL

Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@otelbot-docs otelbot-docs bot requested a review from a team October 15, 2025 13:54
@otelbot-docs
Copy link
Contributor

otelbot-docs bot commented Oct 21, 2025

fix:all applied successfully in run 18695460024.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took another closer look, overall LGTM, review is more around style and some copy-editing.

Comment on lines 141 to 160
```yaml
receivers: ...

processors:
transform:
error_mode: ignore
log_statements:
- context: log
statements:
- set(body, Split(body, "\"},")) where true
unroll: {}
exporters: ...

services:
pipelines:
logs:
receivers: [...]
processors: [transform, unroll]
exporters: [...]
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a duplication of the YAML section before?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah while it is a similar snippet its mostly pertaining to the example I'm trying to highlight for the use case. I'd be happy to think of ways to avoid the yaml dump though. Perhaps the only section needed here is the processors section? WDYT?

Suggested change
```yaml
receivers: ...
processors:
transform:
error_mode: ignore
log_statements:
- context: log
statements:
- set(body, Split(body, "\"},")) where true
unroll: {}
exporters: ...
services:
pipelines:
logs:
receivers: [...]
processors: [transform, unroll]
exporters: [...]
```
```yaml
processors:
transform:
error_mode: ignore
log_statements:
- context: log
statements:
- set(body, Split(body, "\"},")) where true
unroll: {}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only difference I see between this block and the one above is the where true but I am not sure if I understand from the context of the surrounding text what differences this makes:

- set(body, Split(body, "\"},"))

vs

- set(body, Split(body, "\"},")) where true

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the context was more to highlight just the snippets of processors vs the whole otel configuration. I've gone ahead an consolidated to just one YAML snippet!

Where true is similar to a SQL 1=1 where it just makes it easer to add where clauses and not needed. I think with the consolidated config it is an overall improvement!

Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@otelbot-docs otelbot-docs bot requested a review from a team October 22, 2025 13:47
@svrnm svrnm self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

New Blog Post: Contributing the Unroll Processor to the OpenTelemetry Collector Contrib

2 participants