Fix linting problems in portal code

Author: DWJ01

doc/certificates.md

@@ -0,0 +1,6 @@
+# Client side certificate management
+
+We recommand to use default credential storage to verify and manage certificates on different platforms.
+Windows: (https://docs.microsoft.com/en-us/windows-hardware/drivers/install/certificate-stores)
+IOS: (https://developer.apple.com/documentation/security/certificate_key_and_trust_services/certificates)
+Android: (https://developer.android.com/training/articles/security-config)

doc/design/quic-programming-guide.md

@@ -126,11 +126,12 @@ Please follow [Conference Server build instructions](https://github.com/open-web
 Steps to run Conference Server with pre-built binary:
 
 1. Go to the untarred conference server dir, and run `./bin/init-all.sh --deps`; this would try to install mongodb and rabbitmq-server. Don't set any password for rabbitmq or mongodb.
-2. Still in the same dir, run `bin/init-all.sh`.
-3. Update quic_agent/agent.toml, set `hostname` to the hostname quic agent is running on.
-4. run `bin/start-all.sh`.
-5. Open [https://localhost:3004/quic.html](https://localhost:3004/quic.html) on the same host with Chrome browser to visit the web sample page. Due to the test certificate, you may need confirm this unsafe access.
-6. Press 'Start Sending' button to start transferring data to conference server. Press 'Stop Sending' button on the web page to stop sending.. If there's no error in the console, that implies server is correctly setup.
+1. Still in the same dir, run `bin/init-all.sh`.
+1. Update quic_agent/agent.toml, set `hostname` to the hostname quic agent is running on.
+1. Update management_api/management_api.toml, set `enableWebTransport` to `true`.
+1. run `bin/start-all.sh`.
+1. Open [https://localhost:3004/quic.html](https://localhost:3004/quic.html) on the same host with Chrome browser to visit the web sample page. Due to the test certificate, you may need confirm this unsafe access.
+1. Press 'Start Sending' button to start transferring data to conference server. Press 'Stop Sending' button on the web page to stop sending.. If there's no error in the console, that implies server is correctly setup.
 
 # OWT QUIC Windows Sample
 
@@ -152,7 +153,7 @@ OWT Conference Server is using a self-signed certificate during development phas
 - Make sure generate-certs.sh is exectuable. If not, run `chmod +x generate-certs.sh`;
 - Remove the `out` dir in case it exists.
 - Under the downloaded tool dir, run `./generate-certs.sh`. It is expected to generate a series of files under out dir.
-- Under the downloaded tool dir, run `openssl pkcs12 -inkey out/leaf_certs.key -in out/leaf_cert.pem -export -out out/certificate.pfx`. This will prompt for password for the pfx. Make sure you always use `abc123` as the password.
+- Under the downloaded tool dir, run `openssl pkcs12 -inkey out/leaf_cert.key -in out/leaf_cert.pem -export -out out/certificate.pfx`. This will prompt for password for the pfx. Make sure you always use `abc123` as the password.
 - Under the downloaded tool dir, run `openssl x509 -noout -fingerprint -sha256 -inform pem -in out/leaf_cert.pem`. You will get the fingerprint string in the form of "XX:XX:XX....XX:XX".
 
 ## Use the Certificate

scripts/pack.js

@@ -456,7 +456,7 @@ function isLibAllowed(libSrc) {
   const whiteList = [
     'rtcadapter',
     'libssl.so.1.1',
-    'libcrypto',
+    'libcrypto.so.1.1',
     'libnice',
     'libSvtHevcEnc',
     'libusrsctp',

source/.eslintrc.json

@@ -1,13 +1,29 @@
+// Copyright (C) <2018> Intel Corporation
+//
+// SPDX-License-Identifier: Apache-2.0
 {
     "env": {
-        "browser": true,
-        "es2021": true
+        "es2021": true,
+        "node": true
     },
-    "extends": "eslint:recommended",
+    "extends": ["eslint:recommended", "google"],
     "parserOptions": {
-        "ecmaVersion": 12,
-        "sourceType": "module"
+      "ecmaVersion": 12,
+      "sourceType": "module"
     },
     "rules": {
+      "max-len": ["error", {
+        // This line is part of the MIT license.
+        "ignorePattern": "The above copyright notice and this permission notice shall be included in all",
+        // Some lines for JSDoc is longer than 80.
+        "ignoreComments": true
+      }],
+      "indent": ["warn"],
+      "camelcase": 0,
+      "prefer-promise-reject-errors": "off",
+      "guard-for-in": "off",
+      "require-jsdoc": "off",
+      "no-invalid-this": "off",
+      "new-cap": "off"
     }
 }

source/agent/InternalConnectionFactory.js

@@ -39,15 +39,15 @@ try {
 }
 
 // Wrapper object for sctp-connection and tcp/udp-connection
-function InConnection(prot, minport, maxport) {
+function InConnection(prot, minport, maxport, ticket) {
     var conn = null;
     var protocol = "quic";
 
     switch (prot) {
         case 'tcp':
         case 'udp':
             protocol = prot;
-            conn = new InternalIn(prot, minport, maxport);
+            conn = new InternalIn(prot, minport, maxport, ticket);
             break;
         case 'quic':
             conn = new quicIO.in(cf, kf);
@@ -78,7 +78,7 @@ function InConnection(prot, minport, maxport) {
 }
 
 // Wrapper object for sctp-connection and tcp/udp-connection
-function OutConnection(prot, minport, maxport) {
+function OutConnection(prot, minport, maxport, ticket) {
     var that = {};
     var conn = null;
     var protocol = "quic";
@@ -111,7 +111,7 @@ function OutConnection(prot, minport, maxport) {
         } else if (protocol === 'quic') {
             conn = new quicIO.out(connectOpt.ip, connectOpt.port);
         } else {
-            conn = new InternalOut(protocol, connectOpt.ip, connectOpt.port);
+            conn = new InternalOut(protocol, connectOpt.ip, connectOpt.port, ticket);
         }
     };
 
@@ -139,6 +139,7 @@ module.exports = function() {
         var prot = internalOpt.protocol;
         var minport = internalOpt.minport || 0;
         var maxport = internalOpt.maxport || 0;
+        var ticket = internalOpt.ticket;
 
         if (preparedSet[connId]) {
             log.warn('Internal Connection already prepared:', connId);
@@ -147,7 +148,9 @@ module.exports = function() {
             // right call sequence in upper layer.
             return preparedSet[connId].connection.getListeningPort();
         }
-        var conn = (direction === 'in')? InConnection(prot, minport, maxport) : OutConnection(prot, minport, maxport);
+        var conn = (direction === 'in')
+            ? InConnection(prot, minport, maxport, ticket)
+            : OutConnection(prot, minport, maxport, ticket);
 
         preparedSet[connId] = {connection: conn, direction: direction};
         return conn.getListeningPort();

source/agent/addons/internalIO/InternalInWrapper.cc

@@ -37,14 +37,23 @@ void InternalIn::New(const FunctionCallbackInfo<Value>& args) {
   String::Utf8Value param0(args[0]->ToString());
   std::string protocol = std::string(*param0);
   unsigned int minPort = 0, maxPort = 0;
+  std::string ticket;
 
   if (args.Length() >= 3) {
     minPort = args[1]->Uint32Value();
     maxPort = args[2]->Uint32Value();
   }
+  if (args.Length() > 3) {
+    String::Utf8Value param3(args[3]->ToString());
+    ticket = std::string(*param3);
+  }
 
   InternalIn* obj = new InternalIn();
-  obj->me = new owt_base::InternalIn(protocol, minPort, maxPort);
+  if (ticket.empty()) {
+    obj->me = new owt_base::InternalIn(protocol, minPort, maxPort);
+  } else {
+    obj->me = new owt_base::InternalIn(protocol, ticket, minPort, maxPort);
+  }
   obj->src = obj->me;
 
   obj->Wrap(args.This());

source/agent/addons/internalIO/InternalOutWrapper.cc

@@ -36,9 +36,18 @@ void InternalOut::New(const v8::FunctionCallbackInfo<v8::Value>& args) {
   String::Utf8Value param1(args[1]->ToString());
   std::string dest_ip = std::string(*param1);
   unsigned int dest_port = args[2]->Uint32Value();
+  std::string ticket;
+  if (args.Length() > 3) {
+    String::Utf8Value param3(args[3]->ToString());
+    ticket = std::string(*param3);
+  }
 
   InternalOut* obj = new InternalOut();
-  obj->me = new owt_base::InternalOut(protocol, dest_ip, dest_port);
+  if (ticket.empty()) {
+    obj->me = new owt_base::InternalOut(protocol, dest_ip, dest_port);
+  } else {
+    obj->me = new owt_base::InternalOut(protocol, ticket, dest_ip, dest_port);
+  }
   obj->dest = obj->me;
 
   obj->Wrap(args.This());

source/agent/addons/quic/quic_sdk_version

@@ -1 +1 @@
-67301606083eec702fbbe12c768b56948b419c01
+4fda6ee03d3d0a305fe239d968ca4af46f4fda05

source/agent/addons/quic/test/package-lock.json

@@ -25,14 +25,16 @@ class AnalyticsAgent extends BaseAgent {
     this.engine = new VideoAnalyzer();
 
     this.flag = 0;
+    this.ticket = null;
   }
 
 // override
 createInternalConnection(connectionId, direction, internalOpt) {
     internalOpt.minport = global.config.internal.minport;
     internalOpt.maxport = global.config.internal.maxport;
+    this.ticket = internalOpt.ticket;
     if (direction == 'in') {
-      this.engine.emitListenTo(internalOpt.minport,internalOpt.maxport);
+      this.engine.emitListenTo(internalOpt.minport,internalOpt.maxport, this.ticket);
       const portInfo = this.engine.getListeningPort();
       // Create internal connection always success
       return Promise.resolve({ip: global.config.internal.ip_address, port: portInfo});

source/agent/analytics/analytics-agent.js

@@ -19,10 +19,11 @@ static void dump(void* index, uint8_t* buf, int len)
 }
 
 DEFINE_LOGGER(GstInternalIn, "GstInternalIn");
-GstInternalIn::GstInternalIn(GstAppSrc *data, unsigned int minPort, unsigned int maxPort)
+GstInternalIn::GstInternalIn(GstAppSrc *data, unsigned int minPort, unsigned int maxPort, std::string ticket)
 {
     m_transport.reset(new owt_base::RawTransport<owt_base::TCP>(this));
 
+    m_transport->initTicket(ticket);
     if (minPort > 0 && minPort <= maxPort) {
         m_transport->listenTo(minPort, maxPort);
     } else {

source/agent/analytics/videoGstPipeline/GstInternalIn.cpp

@@ -16,7 +16,7 @@
 class GstInternalIn : public owt_base::RawTransportListener{
     DECLARE_LOGGER();
 public:
-    GstInternalIn(GstAppSrc *data, unsigned int minPort = 0, unsigned int maxPort = 0);
+    GstInternalIn(GstAppSrc *data, unsigned int minPort = 0, unsigned int maxPort = 0, std::string ticket = NULL);
     virtual ~GstInternalIn();
 
     unsigned int getListeningPort();

source/agent/analytics/videoGstPipeline/GstInternalIn.h

@@ -352,10 +352,9 @@ int VideoGstAnalyzer::setPlaying()
     return 0;
 }
 
-void VideoGstAnalyzer::emitListenTo(int minPort, int maxPort)
-{
+void VideoGstAnalyzer::emitListenTo(int minPort, int maxPort, std::string ticket) {
     ELOG_DEBUG("Listening\n");
-    m_internalin.reset(new GstInternalIn((GstAppSrc*)source, minPort, maxPort));  
+    m_internalin.reset(new GstInternalIn((GstAppSrc*)source, minPort, maxPort, ticket));
 }
 
 void VideoGstAnalyzer::addOutput(int connectionID, owt_base::FrameDestination* out)

source/agent/analytics/videoGstPipeline/VideoGstAnalyzer.cc

@@ -30,7 +30,7 @@ class VideoGstAnalyzer : public EventRegistry {
     void clearPipeline();
     void destroyPipeline();
     int getListeningPort();
-    void emitListenTo(int minPort,int maxPort);
+    void emitListenTo(int minPort, int maxPort, std::string ticket);
     int setPlaying();
 
     int addElementMany();

source/agent/analytics/videoGstPipeline/VideoGstAnalyzer.h

@@ -97,11 +97,17 @@ void VideoGstAnalyzerWrap::emitListenTo(const FunctionCallbackInfo<Value>& args)
   mcu::VideoGstAnalyzer* me = obj->me;
 
   unsigned int minPort = 0, maxPort = 0;
+  std::string ticket;
 
+  if (args.Length() >= 3) {
     minPort = args[0]->Uint32Value();
     maxPort = args[1]->Uint32Value();
 
-  me->emitListenTo(minPort,maxPort);
+    String::Utf8Value param3(args[2]->ToString());
+    ticket = std::string(*param3);
+  }
+  me->emitListenTo(minPort, maxPort, ticket);
+
 }
 
 

source/agent/analytics/videoGstPipeline/VideoGstAnalyzerWrap.cc

@@ -7,6 +7,7 @@
     "node-getopt": "*",
     "toml": "*",
     "mongoose": "^5.9.6",
+    "uuid": "^8.0.0",
     "fraction.js": "^4.0.12"
   },
   "devDependencies": {

source/agent/conference/package.json

@@ -11,6 +11,8 @@ var makeRPC = require('./makeRPC').makeRPC;
 // Logger
 var log = logger.getLogger('RoomController');
 
+const { v4 : uuid } = require('uuid');
+
 const {
     isVideoFmtCompatible,
     isResolutionEqual,
@@ -40,12 +42,14 @@ module.exports.create = function (spec, on_init_ok, on_init_failed) {
         rpcClient = spec.rpcClient,
         config = spec.config,
         room_id = spec.room,
-	origin = spec.origin,
+        origin = spec.origin,
         selfRpcId = spec.selfRpcId,
         enable_audio_transcoding = config.transcoding && !!config.transcoding.audio,
         enable_video_transcoding = config.transcoding && !!config.transcoding.video,
         internal_conn_protocol = config.internalConnProtocol;
 
+    var internalTicket = uuid().replace(/-/g, '');
+
     /*
     mix_views = {
         view: {
@@ -524,7 +528,8 @@ module.exports.create = function (spec, on_init_ok, on_init_failed) {
 
         // Transport protocol for creating internal connection
         var internalOpt = {
-            protocol: internal_conn_protocol
+            protocol: internal_conn_protocol,
+            ticket: internalTicket,
         };
         var from, to, has_published, has_subscribed;
 

source/agent/conference/roomController.js

@@ -129,8 +129,12 @@ module.exports = function (spec, spawnOptions, onNodeAbnormallyQuit, onTaskAdded
           } else {
               child.READY = false;
               child.kill();
-              fs.closeSync(child.out_log_fd);
-              fs.closeSync(child.err_log_fd);
+              try {
+                  fs.closeSync(child.out_log_fd);
+                  fs.closeSync(child.err_log_fd);
+              } catch (e) {
+                  log.warn('Close fd failed');
+              }
               cleanupNode(id);
           }
       });

source/agent/nodeManager.js

@@ -96,6 +96,16 @@ process.on('exit', function () {
     //rpc.disconnect();
 });
 
+process.on('uncaughtException', async (err) => {
+    log.error(err);
+    try {
+        await rpc.disconnect();
+    } catch(e) {
+        log.warn('Exiting e:', e);
+    }
+    process.exit(1);
+});
+
 process.on('unhandledRejection', (reason) => {
     log.info('Reason: ' + reason);
 });